WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172364
Reduce Safari Technology Preview Release Notes posts shown on homepage
https://bugs.webkit.org/show_bug.cgi?id=172364
Summary
Reduce Safari Technology Preview Release Notes posts shown on homepage
Jon Davis
Reported
2017-05-19 09:55:57 PDT
We want to highlight the latest Safari Technology Preview release notes when they are the current post, but otherwise, show more of our other blog content.
Attachments
Patch
(3.66 KB, patch)
2017-05-19 09:57 PDT
,
Jon Davis
no flags
Details
Formatted Diff
Diff
Patch
(3.55 KB, patch)
2017-05-31 11:20 PDT
,
Jon Davis
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jon Davis
Comment 1
2017-05-19 09:57:52 PDT
Created
attachment 310667
[details]
Patch
Daniel Bates
Comment 2
2017-05-25 21:54:42 PDT
Comment on
attachment 310667
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=310667&action=review
Looks sane to me
> Websites/webkit.org/ChangeLog:8 > + * wp-content/themes/webkit/functions.php: Load some extra posts
Nit: Missing period at the end of this sentence.
> Websites/webkit.org/ChangeLog:9 > + * wp-content/themes/webkit/widgets/post.php: Show STP blog posts when it is the current featured post
Ditto.
> Websites/webkit.org/wp-content/themes/webkit/functions.php:420 > +
Please remove this whitespace.
> Websites/webkit.org/wp-content/themes/webkit/widgets/post.php:35 > + if ( ! $featured) {
Nit: Missing space before the ')'.
> Websites/webkit.org/wp-content/themes/webkit/widgets/post.php:36 > + // Prevent Safari Technology Preview release note posts from showing up when not a featured post
Nit: Missing a period at the end of this sentence.
Jon Davis
Comment 3
2017-05-31 11:20:41 PDT
Created
attachment 311612
[details]
Patch
WebKit Commit Bot
Comment 4
2017-05-31 11:57:15 PDT
Comment on
attachment 311612
[details]
Patch Clearing flags on attachment: 311612 Committed
r217614
: <
http://trac.webkit.org/changeset/217614
>
WebKit Commit Bot
Comment 5
2017-05-31 11:57:17 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug