Bug 172332 - cp949 is not a known text encoding name
Summary: cp949 is not a known text encoding name
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-18 19:13 PDT by Myles C. Maxfield
Modified: 2017-05-19 09:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.70 KB, patch)
2017-05-18 19:18 PDT, Myles C. Maxfield 		ap: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-05-18 19:13:51 PDT 
cp949 is not a known text encoding name
Comment 1 Myles C. Maxfield 2017-05-18 19:18:27 PDT 
Created attachment 310592 [details]
Patch
Comment 2 Myles C. Maxfield 2017-05-18 19:19:14 PDT 
<rdar://problem/29133333>
Comment 3 Alexey Proskuryakov 2017-05-18 20:33:46 PDT 
Comment on attachment 310592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310592&action=review

> Source/WebCore/ChangeLog:5
> +        <rdar://problem/29133333>

I can't check radar right now, but I think that it's intentional. Could you hold off landing?
Comment 4 Alexey Proskuryakov 2017-05-19 09:52:18 PDT 
Comment on attachment 310592 [details]
Patch

I don't think that we should do this.

1. This encoding name is not in the Web encoding spec <https://encoding.spec.whatwg.org>, and other browsers don't support it.

2. The way this patch implements cp949 doesn't match any non-Web encoding standard either. In ICU, this name maps to ibm-949 encoding, which is entirely different from windows-949: <http://demo.icu-project.org/icu-bin/convexp?s=IANA&s=MIME&s=ALL>. I think that it's a bug somewhere in the client that it passes cp949 when it actually means windows-949 or some other EUC-KR variant.