Bug 172329 - webkitSupportsFullscreen and webkitSupportsPresentationMode('fullscreen') disagree.
Summary: webkitSupportsFullscreen and webkitSupportsPresentationMode('fullscreen') dis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-18 18:26 PDT by Jeremy Jones
Modified: 2017-06-08 14:57 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2017-05-18 18:30 PDT, Jeremy Jones 		darin: review+
Details | Formatted Diff | Diff
Patch for landing. (6.24 KB, patch)
2017-05-19 14:56 PDT, Jeremy Jones 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.10 MB, application/zip)
2017-05-19 15:38 PDT, Build Bot 		no flags Details
Patch for landing. (9.95 KB, patch)
2017-05-19 15:58 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-05-18 18:26:34 PDT 
webkitSupportsFullscreen and webkitSupportsPresentationMode('fullscreen') disagree.
Comment 1 Jeremy Jones 2017-05-18 18:28:19 PDT 
rdar://problem/32260891
Comment 2 Jeremy Jones 2017-05-18 18:30:40 PDT 
Created attachment 310588 [details]
Patch
Comment 3 Jon Lee 2017-05-18 20:00:41 PDT 
Can we add a test, please?
Comment 4 Jeremy Jones 2017-05-19 14:56:56 PDT 
Created attachment 310703 [details]
Patch for landing.
Comment 5 Jeremy Jones 2017-05-19 14:57:53 PDT 
(In reply to Jon Lee from comment #3)
> Can we add a test, please?

Updated a couple existing tests to test this functionality.
Comment 6 Build Bot 2017-05-19 15:38:03 PDT 
Comment on attachment 310703 [details]
Patch for landing.

Attachment 310703 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3779152

New failing tests:
media/media-fullscreen-inline.html
Comment 7 Build Bot 2017-05-19 15:38:04 PDT 
Created attachment 310711 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Jeremy Jones 2017-05-19 15:57:16 PDT 
Updating test expectation of El Capitan where there is no webkitSuppportsPresentationMode
Comment 9 Jeremy Jones 2017-05-19 15:58:51 PDT 
Created attachment 310718 [details]
Patch for landing.
Comment 10 WebKit Commit Bot 2017-05-19 17:27:36 PDT 
Comment on attachment 310718 [details]
Patch for landing.

Clearing flags on attachment: 310718

Committed r217176: <http://trac.webkit.org/changeset/217176>