Bug 172309 - Redundant ellipsis box triggers ASSERT_WITH_SECURITY_IMPLICATION in InlineBox::parent().
Summary: Redundant ellipsis box triggers ASSERT_WITH_SECURITY_IMPLICATION in InlineBox...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-18 14:09 PDT by zalan
Modified: 2017-05-19 15:54 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.76 KB, patch)
2017-05-18 16:18 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (7.77 KB, patch)
2017-05-18 16:57 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (7.80 KB, patch)
2017-05-19 08:04 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (7.88 KB, patch)
2017-05-19 15:13 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-05-18 14:09:19 PDT
but in this case, it is not a security issue at all -not even an issue.

rdar://problem/32262357
Comment 1 zalan 2017-05-18 16:18:51 PDT
Created attachment 310571 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-05-18 16:54:36 PDT
Comment on attachment 310571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310571&action=review

> Source/WebCore/rendering/InlineBox.h:416
> +    bool m_inChildList { true };

Maybe call this m_isEverInChildList, or even m_isEllipsisBox.
Comment 3 zalan 2017-05-18 16:57:44 PDT
Created attachment 310576 [details]
Patch
Comment 4 WebKit Commit Bot 2017-05-18 17:37:47 PDT
Comment on attachment 310576 [details]
Patch

Clearing flags on attachment: 310576

Committed r217079: <http://trac.webkit.org/changeset/217079>
Comment 5 WebKit Commit Bot 2017-05-18 17:37:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryan Haddad 2017-05-18 20:23:34 PDT
(In reply to WebKit Commit Bot from comment #4)
> Comment on attachment 310576 [details]
> Patch
> 
> Clearing flags on attachment: 310576
> 
> Committed r217079: <http://trac.webkit.org/changeset/217079>
This change broke the Windows debug build, as well as some internal builds: https://build.webkit.org/builders/Apple%20Win%20Debug%20(Build)/builds/1419
Comment 7 Ryan Haddad 2017-05-18 20:28:12 PDT
Reverted r217079 for reason:

This change broke internal builds.

Committed r217092: <http://trac.webkit.org/changeset/217092>
Comment 8 zalan 2017-05-19 08:04:37 PDT
Created attachment 310656 [details]
Patch
Comment 9 zalan 2017-05-19 15:13:46 PDT
Created attachment 310707 [details]
Patch
Comment 10 WebKit Commit Bot 2017-05-19 15:54:10 PDT
Comment on attachment 310707 [details]
Patch

Clearing flags on attachment: 310707

Committed r217164: <http://trac.webkit.org/changeset/217164>
Comment 11 WebKit Commit Bot 2017-05-19 15:54:11 PDT
All reviewed patches have been landed.  Closing bug.