Bug 172307 – Make WebRTC logging happen in Release

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

This will allow easier debugging

[youenn fablet]

Created attachment 310540 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 310540 [details]
Patch

This logging doesn't look useful. I don't see logging on any error conditions.

[youenn fablet]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 310540 [details]
> Patch
> 
> This logging doesn't look useful. I don't see logging on any error
> conditions.

This logging allows to see what are the parameters of the session.
This is extremely useful when you are not controlling the website or the other endpoint.

What we do not have here:
- Whether the network connection is successful or not. This should be added as a follow-up. Useful when you are not sure of the network
- The state of the network connection once successful. This might be perf sensitive but would be useful as long as we do not have some inspector functionality similar to chrome:://webrtc-internals.
- Any media element state. This should also be added as a follow-up. Useful when we have issues with autoplay and such.

[WebKit Commit Bot]

Comment on attachment 310540 [details]
Patch

Clearing flags on attachment: 310540

Committed r217082: <http://trac.webkit.org/changeset/217082>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.