WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172297
RealtimeOutgoingAudioSource should use the source sample rate
https://bugs.webkit.org/show_bug.cgi?id=172297
Summary
RealtimeOutgoingAudioSource should use the source sample rate
youenn fablet
Reported
2017-05-18 11:21:27 PDT
Currently it expects the data to be 48000
Attachments
Patch
(2.12 KB, patch)
2017-05-18 11:23 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2017-05-18 11:23:50 PDT
Created
attachment 310520
[details]
Patch
Eric Carlson
Comment 2
2017-05-18 11:38:16 PDT
Comment on
attachment 310520
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=310520&action=review
> Source/WebCore/ChangeLog:11 > + (WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable): Using the audio source sample rate so that the converter does the right conversion.
Nit: this line is too long. Nit: "Using" => "Use".
Radar WebKit Bug Importer
Comment 3
2017-05-18 11:41:02 PDT
<
rdar://problem/32277335
>
WebKit Commit Bot
Comment 4
2017-05-18 12:07:58 PDT
Comment on
attachment 310520
[details]
Patch Clearing flags on attachment: 310520 Committed
r217058
: <
http://trac.webkit.org/changeset/217058
>
WebKit Commit Bot
Comment 5
2017-05-18 12:07:59 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug