Bug 172297 - RealtimeOutgoingAudioSource should use the source sample rate
Summary: RealtimeOutgoingAudioSource should use the source sample rate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-18 11:21 PDT by youenn fablet
Modified: 2017-05-18 12:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2017-05-18 11:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-05-18 11:21:27 PDT 
Currently it expects the data to be 48000
Comment 1 youenn fablet 2017-05-18 11:23:50 PDT 
Created attachment 310520 [details]
Patch
Comment 2 Eric Carlson 2017-05-18 11:38:16 PDT 
Comment on attachment 310520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310520&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable): Using the audio source sample rate so that the converter does the right conversion.

Nit: this line is too long.
Nit: "Using" => "Use".
Comment 3 Radar WebKit Bug Importer 2017-05-18 11:41:02 PDT 
<rdar://problem/32277335>
Comment 4 WebKit Commit Bot 2017-05-18 12:07:58 PDT 
Comment on attachment 310520 [details]
Patch

Clearing flags on attachment: 310520

Committed r217058: <http://trac.webkit.org/changeset/217058>
Comment 5 WebKit Commit Bot 2017-05-18 12:07:59 PDT 
All reviewed patches have been landed.  Closing bug.