Bug 172288 – [Readable Streams API] Align respondInClosedState with spec

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Romain Bellessort]

The issue reported to GH [1] while working on bug 168781 has now been fixed. 
WebKit implementation should be aligned with corresponding fix.

[1] https://github.com/whatwg/streams/issues/686

[Romain Bellessort]

Created attachment 310512 [details]
Patch

[Chris Dumez]

Comment on attachment 310512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310512&action=review

> Source/WebCore/ChangeLog:17
> +        No added test (already covered by existing tests).

You cannot say that the behavior change is covered by existing tests but then not rebaseline those tests in the patch. Either:
1. This patch does not change Web-facing behavior
2. The existing tests do not cover the behavior change and more testing should be added

[Chris Dumez]

Comment on attachment 310512 [details]
Patch

r=me. Code change looks fine but please fix the Changelog to explain that this is not testable (if I understand correctly). If it is testable, please add a test.

[Romain Bellessort]

Created attachment 311009 [details]
Patch

[Romain Bellessort]

Thanks for the comment, I updated the ChangeLog to clarify why there was no added test nor updated test expectations (one change does not impact behavior, and the other one is not reachable for the moment).

[WebKit Commit Bot]

Comment on attachment 311009 [details]
Patch

Clearing flags on attachment: 311009

Committed r217279: <http://trac.webkit.org/changeset/217279>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.