Bug 172286 - [Win] Many layout tests are failing.
Summary: [Win] Many layout tests are failing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-18 06:28 PDT by Per Arne Vollan
Modified: 2017-05-18 11:28 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.02 KB, patch)
2017-05-18 06:34 PDT, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-05-18 06:28:49 PDT
The following line of text appears unexpectedly in many test results:

ERROR: TestRunner::grantWebNotificationPermission(JSStringRef) not implemented
Comment 1 Per Arne Vollan 2017-05-18 06:34:15 PDT
Created attachment 310504 [details]
Patch
Comment 2 Brent Fulgham 2017-05-18 09:39:43 PDT
Comment on attachment 310504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310504&action=review

> Tools/ChangeLog:8
> +        Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.

Can you please file a Bugzilla to implement the work, and then include it in the Fixme's below?
Comment 3 Per Arne Vollan 2017-05-18 11:28:01 PDT
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 310504 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310504&action=review
> 
> > Tools/ChangeLog:8
> > +        Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
> 
> Can you please file a Bugzilla to implement the work, and then include it in
> the Fixme's below?

Thanks for reviewing! I will update the patch with Bugzilla links before landing.
Comment 4 Per Arne Vollan 2017-05-18 11:28:23 PDT
Committed <https://trac.webkit.org/changeset/217053/webkit>