Bug 172257 - r216999 broke win build
Summary: r216999 broke win build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-17 19:19 PDT by youenn fablet
Modified: 2017-05-17 21:07 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.09 KB, patch)
2017-05-17 19:21 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (2.18 KB, patch)
2017-05-17 20:26 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-05-17 19:19:38 PDT
r216999 broke win build
Comment 1 youenn fablet 2017-05-17 19:21:45 PDT
Created attachment 310472 [details]
Patch
Comment 2 WebKit Commit Bot 2017-05-17 19:29:07 PDT
Comment on attachment 310472 [details]
Patch

Rejecting attachment 310472 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 310472, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/testing/Internals.cpp
Hunk #2 FAILED at 4043.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/testing/Internals.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3766262
Comment 3 youenn fablet 2017-05-17 20:26:47 PDT
Created attachment 310479 [details]
Patch
Comment 4 WebKit Commit Bot 2017-05-17 21:07:26 PDT
Comment on attachment 310479 [details]
Patch

Clearing flags on attachment: 310479

Committed r217030: <http://trac.webkit.org/changeset/217030>
Comment 5 WebKit Commit Bot 2017-05-17 21:07:27 PDT
All reviewed patches have been landed.  Closing bug.