Bug 172246 - [WK2] Notify client when a process exceeds background CPU limit while in the foreground
Summary: [WK2] Notify client when a process exceeds background CPU limit while in the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 172244
Blocks:
  Show dependency tree / graph
 
Reported: 2017-05-17 15:04 PDT by Chris Dumez
Modified: 2017-05-19 15:11 PDT (History)
4 users (show)

See Also:

Attachments
WIP Patch (18.69 KB, patch)
2017-05-17 15:05 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (24.38 KB, patch)
2017-05-19 12:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-17 15:04:16 PDT 
Notify client when a process exceeds background CPU limit while in the foreground.
Comment 1 Chris Dumez 2017-05-17 15:04:44 PDT 
<rdar://problem/32235411>
Comment 2 Chris Dumez 2017-05-17 15:05:49 PDT 
Created attachment 310450 [details]
WIP Patch
Comment 3 Chris Dumez 2017-05-17 15:08:26 PDT 
Comment on attachment 310450 [details]
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310450&action=review

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:1167
> +            // FIXME: We should call a delegate to notify the client we exceeded the background CPU limit while in the foreground (i.e. we would have terminated the process if it weren't visible).

I am holding off on this part since Andreas seems pretty far along on Bug 172244, and we'll likely use the same client callback (with a different parameter).
Comment 4 Chris Dumez 2017-05-19 12:55:05 PDT 
Created attachment 310687 [details]
Patch
Comment 5 Geoffrey Garen 2017-05-19 14:42:05 PDT 
Comment on attachment 310687 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2017-05-19 15:11:19 PDT 
Comment on attachment 310687 [details]
Patch

Clearing flags on attachment: 310687

Committed r217153: <http://trac.webkit.org/changeset/217153>
Comment 7 WebKit Commit Bot 2017-05-19 15:11:20 PDT 
All reviewed patches have been landed.  Closing bug.