Bug 172245 - [MediaStream] do not cache gUM permissions
Summary: [MediaStream] do not cache gUM permissions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-17 14:57 PDT by Eric Carlson
Modified: 2022-10-05 16:22 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch. (27.12 KB, patch)
2017-05-18 06:35 PDT, Eric Carlson 		youennf: review+
Details | Formatted Diff | Diff
Patch for landing. (27.17 KB, patch)
2017-05-18 10:26 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing. (29.66 KB, patch)
2017-05-18 10:45 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing. (22.55 KB, patch)
2017-05-18 11:57 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing. (31.91 KB, patch)
2017-05-18 13:10 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2017-05-17 14:57:02 PDT 
WebKit should alway ask the user agent for permission to access devices. The user agent can choose to cache responses if it wants to.
Comment 1 Eric Carlson 2017-05-18 06:35:21 PDT 
Created attachment 310505 [details]
Proposed patch.
Comment 2 Radar WebKit Bug Importer 2017-05-18 06:36:00 PDT 
<rdar://problem/32271110>
Comment 3 youenn fablet 2017-05-18 08:03:56 PDT 
Comment on attachment 310505 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=310505&action=review

> Source/WebKit2/UIProcess/UserMediaPermissionRequestProxy.cpp:41
> +    , m_deviceIdentifierHashSalt(deviceIDHashSalt)

WTFMove
Comment 4 Eric Carlson 2017-05-18 10:26:35 PDT 
Created attachment 310515 [details]
Patch for landing.
Comment 5 Eric Carlson 2017-05-18 10:45:56 PDT 
Created attachment 310519 [details]
Patch for landing.
Comment 6 Eric Carlson 2017-05-18 11:57:28 PDT 
Created attachment 310525 [details]
Patch for landing.
Comment 7 Eric Carlson 2017-05-18 13:10:43 PDT 
Created attachment 310541 [details]
Patch for landing.
Comment 8 WebKit Commit Bot 2017-05-18 18:16:51 PDT 
Comment on attachment 310541 [details]
Patch for landing.

Clearing flags on attachment: 310541

Committed r217081: <http://trac.webkit.org/changeset/217081>
Comment 9 Ahmad Saleem 2022-10-05 16:22:43 PDT 
It seems landed but didn't backed out based on each on Webkit GitHub with BugID:

https://github.com/WebKit/WebKit/commit/39b1840ee9c0a82b8944dd902415b78d7838c083

Marking this as "RESOLVED FIXED". Thanks!