Bug 172237 - Baseline of number inputs not right
Summary: Baseline of number inputs not right
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-17 12:39 PDT by Dave Hyatt
Modified: 2017-06-07 14:22 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.20 KB, patch)
2017-05-17 12:41 PDT, Dave Hyatt
dino: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-elcapitan (2.13 MB, application/zip)
2017-05-17 13:42 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.32 MB, application/zip)
2017-05-17 13:51 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (14.02 MB, application/zip)
2017-05-17 14:00 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews100 for mac-elcapitan (1.28 MB, application/zip)
2017-05-17 14:38 PDT, Build Bot
no flags Details
Patch (38.74 KB, patch)
2017-05-24 12:53 PDT, Dave Hyatt
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.15 MB, application/zip)
2017-05-24 13:51 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (10.57 MB, application/zip)
2017-05-24 13:55 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.06 MB, application/zip)
2017-05-24 13:56 PDT, Build Bot
no flags Details
Patch (39.05 KB, patch)
2017-05-24 14:13 PDT, Dave Hyatt
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-elcapitan (1.94 MB, application/zip)
2017-05-24 14:20 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (923.39 KB, application/zip)
2017-05-24 15:38 PDT, Build Bot
no flags Details
Patch (39.05 KB, patch)
2017-05-25 07:46 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2017-05-17 12:39:35 PDT
Baseline of number inputs not right
Comment 1 Dave Hyatt 2017-05-17 12:41:30 PDT
Created attachment 310428 [details]
Patch
Comment 2 Build Bot 2017-05-17 13:42:47 PDT
Comment on attachment 310428 [details]
Patch

Attachment 310428 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3764448

New failing tests:
fast/forms/number/number-appearance-rtl.html
fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/block/float/032.html
fast/forms/input-appearance-spinbutton-up.html
fast/forms/input-appearance-spinbutton.html
fast/forms/number/number-large-padding.html
fast/forms/number/number-spinbutton-in-multi-column.html
fast/forms/search-vertical-alignment.html
fast/forms/number/number-appearance-spinbutton-layer.html
Comment 3 Build Bot 2017-05-17 13:42:49 PDT
Created attachment 310436 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-05-17 13:51:56 PDT
Comment on attachment 310428 [details]
Patch

Attachment 310428 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3764521

New failing tests:
fast/forms/number/number-appearance-rtl.html
fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/block/float/032.html
fast/forms/input-appearance-spinbutton-up.html
fast/forms/input-appearance-spinbutton.html
fast/forms/number/number-large-padding.html
fast/forms/number/number-spinbutton-in-multi-column.html
fast/forms/search-vertical-alignment.html
fast/forms/number/number-appearance-spinbutton-layer.html
Comment 5 Build Bot 2017-05-17 13:51:57 PDT
Created attachment 310438 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-05-17 14:00:19 PDT
Comment on attachment 310428 [details]
Patch

Attachment 310428 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3764473

New failing tests:
fast/forms/input-text-word-wrap.html
fast/forms/visual-hebrew-text-field.html
fast/forms/search-vertical-alignment.html
fast/forms/searchfield-heights.html
fast/forms/search-rtl.html
Comment 7 Build Bot 2017-05-17 14:00:21 PDT
Created attachment 310442 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-05-17 14:38:42 PDT
Comment on attachment 310428 [details]
Patch

Attachment 310428 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3764790

New failing tests:
fast/forms/number/number-appearance-rtl.html
fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/block/float/032.html
fast/forms/input-appearance-spinbutton-up.html
fast/forms/input-appearance-spinbutton.html
fast/forms/number/number-large-padding.html
fast/forms/number/number-spinbutton-in-multi-column.html
fast/forms/search-vertical-alignment.html
fast/forms/number/number-appearance-spinbutton-layer.html
Comment 9 Build Bot 2017-05-17 14:38:43 PDT
Created attachment 310447 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 10 Dave Hyatt 2017-05-24 12:53:03 PDT
Created attachment 311146 [details]
Patch
Comment 11 Build Bot 2017-05-24 12:55:41 PDT
Attachment 311146 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderTextControlSingleLine.cpp:142:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Build Bot 2017-05-24 13:51:18 PDT
Comment on attachment 311146 [details]
Patch

Attachment 311146 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3808612

New failing tests:
fast/forms/number/number-appearance-rtl.html
fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/forms/input-appearance-spinbutton-up.html
fast/forms/input-appearance-spinbutton.html
fast/forms/search-vertical-alignment.html
fast/forms/number/number-appearance-spinbutton-layer.html
Comment 13 Build Bot 2017-05-24 13:51:19 PDT
Created attachment 311149 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 14 Build Bot 2017-05-24 13:55:53 PDT
Comment on attachment 311146 [details]
Patch

Attachment 311146 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3808544

New failing tests:
http/tests/cache/cancel-during-revalidation-succeeded.html
Comment 15 Build Bot 2017-05-24 13:55:55 PDT
Created attachment 311150 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 16 Build Bot 2017-05-24 13:56:10 PDT
Comment on attachment 311146 [details]
Patch

Attachment 311146 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3808615

New failing tests:
fast/forms/number/number-appearance-rtl.html
fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/forms/input-appearance-spinbutton-up.html
fast/forms/input-appearance-spinbutton.html
fast/forms/search-vertical-alignment.html
fast/forms/number/number-appearance-spinbutton-layer.html
Comment 17 Build Bot 2017-05-24 13:56:11 PDT
Created attachment 311151 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 18 Dave Hyatt 2017-05-24 14:13:32 PDT
Created attachment 311152 [details]
Patch
Comment 19 Build Bot 2017-05-24 14:20:30 PDT
Comment on attachment 311146 [details]
Patch

Attachment 311146 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3808636

New failing tests:
fast/forms/number/number-appearance-rtl.html
fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/forms/input-appearance-spinbutton-up.html
fast/forms/input-appearance-spinbutton.html
fast/forms/search-vertical-alignment.html
fast/forms/number/number-appearance-spinbutton-layer.html
Comment 20 Build Bot 2017-05-24 14:20:32 PDT
Created attachment 311154 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 21 Build Bot 2017-05-24 15:38:22 PDT
Comment on attachment 311152 [details]
Patch

Attachment 311152 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3808951

New failing tests:
fast/events/before-unload-returnValue.html
Comment 22 Build Bot 2017-05-24 15:38:24 PDT
Created attachment 311161 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 23 Dave Hyatt 2017-05-25 07:46:10 PDT
Created attachment 311217 [details]
Patch
Comment 24 Dave Hyatt 2017-05-25 07:56:39 PDT
Landed in r217418.
Comment 25 Alexey Proskuryakov 2017-06-07 14:20:43 PDT
Comment on attachment 311217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311217&action=review

> LayoutTests/platform/mac-elcapitan/TestExpectations:6
> +fast/forms/number/number-appearance-rtl.html [ Skip ]
> +fast/forms/number/number-appearance-spinbutton-disabled-readonly.html [ Skip ]
> +fast/forms/input-appearance-spinbutton-up.html [ Skip ]
> +fast/forms/input-appearance-spinbutton.html [ Skip ]
> +fast/forms/search-vertical-alignment.html [ Skip ]
> +fast/forms/number/number-appearance-spinbutton-layer.html [ Skip ]

It's not an accident that this file didn't exist after all these years of El Capitan being available.

El Capitan expectations should be in platform/mac/TestExpectations with [ ElCapitan ] modifier.
Comment 26 Alexey Proskuryakov 2017-06-07 14:22:04 PDT
It's also unclear to me why skipping was appropriate in the first place. Don't we want EWS to keep running these tests?