Bug 172236 - Cleanup: Remove unnecessary call to AddToImplIncludes("RuntimeEnabledFeatures.h") in GenerateImplementation()
Summary: Cleanup: Remove unnecessary call to AddToImplIncludes("RuntimeEnabledFeatures...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-17 12:19 PDT by Daniel Bates
Modified: 2017-05-18 11:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2017-05-17 12:20 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-05-17 12:19:06 PDT 
It is unnecessary for GenerateImplementation() to explicitly call AddToImplIncludes("RuntimeEnabledFeatures.h") to add the header RuntimeEnabledFeatures.h to the list of headers in the generated implementation as this header is added when GetRuntimeEnableFunctionName() is called. And GenerateImplementation() calls GetRuntimeEnableFunctionName().
Comment 1 Daniel Bates 2017-05-17 12:20:04 PDT 
Created attachment 310426 [details]
Patch
Comment 2 Chris Dumez 2017-05-17 15:10:08 PDT 
Comment on attachment 310426 [details]
Patch

r=me
Comment 3 Daniel Bates 2017-05-18 11:56:37 PDT 
Comment on attachment 310426 [details]
Patch

Clearing flags on attachment: 310426

Committed r217056: <http://trac.webkit.org/changeset/217056>
Comment 4 Daniel Bates 2017-05-18 11:56:39 PDT 
All reviewed patches have been landed.  Closing bug.