...
And we should convert GetByVal(..., String:"499") to GetByVal(..., Int32:499).
(In reply to Yusuke Suzuki from comment #1) > And we should convert GetByVal(..., String:"499") to GetByVal(..., > Int32:499). I would like to do it in a separate patch. https://bugs.webkit.org/show_bug.cgi?id=172358
Created attachment 310757 [details] Patch
Comment on attachment 310757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310757&action=review r=me > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:585 > + if (leftHandSideNeedsCopy(rightHasAssignments, rightIsPure)) { > + RefPtr<RegisterID> dst = newTemporary(); > + emitNodeForProperty(dst.get(), n); > + return dst; > + } Do you have a test for this?
Comment on attachment 310757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310757&action=review Thanks! >> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:585 >> + } > > Do you have a test for this? Nice, added.
Committed r217199: <http://trac.webkit.org/changeset/217199>
Committed r217201: <http://trac.webkit.org/changeset/217201>
https://arewefastyet.com/#machine=29&view=single&suite=six-speed&subtest=map-string-es5 Go!