Bug 172219 – CSSOM insertRule() index argument is optional with default 0

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Sendilkumarn]

To make index argument optional in insertRule with default 0

Please refer 

CSSWG-Draft
https://github.com/w3c/csswg-drafts/commit/7949d41a2d86107f8ad4624c055b4b0c9c28ad0d

Also bugs @
https://www.w3.org/Bugs/Public/show_bug.cgi?id=27384

Added webplatform tests via this issue
https://github.com/w3c/web-platform-tests/issues/5524

Thanks

[Chris Dumez]

Created attachment 310599 [details]
Patch

[Chris Dumez]

Created attachment 310601 [details]
Patch

[Build Bot]

Comment on attachment 310601 [details]
Patch

Attachment 310601 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3773734

New failing tests:
imported/w3c/web-platform-tests/cssom/MediaList.xhtml

[Build Bot]

Created attachment 310608 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310601 [details]
Patch

Attachment 310601 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3773750

New failing tests:
imported/w3c/web-platform-tests/cssom/MediaList.xhtml

[Build Bot]

Created attachment 310610 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310601 [details]
Patch

Attachment 310601 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3773739

New failing tests:
imported/w3c/web-platform-tests/cssom/MediaList.xhtml

[Build Bot]

Created attachment 310612 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Chris Dumez]

Comment on attachment 310601 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310601&action=review

> LayoutTests/imported/w3c/ChangeLog:28
> +        * web-platform-tests/cssom/MediaList.xhtml: Added.

Arg. that won't work. 2 files with name name but different extension. They get the same -expected.txt file. @Youenn: Isn't our importer supposed to deal with this somehow?

[Chris Dumez]

Created attachment 310617 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 310617 [details]
Patch

Clearing flags on attachment: 310617

Committed r217125: <http://trac.webkit.org/changeset/217125>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.