Bug 172218 – URLSearchParams / Headers objects @@iterator is not as per Web IDL spec

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Anne van Kesteren]

Tests:

  https://w3c-test.org/url/interfaces.any.html
  https://w3c-test.org/url/interfaces.any.worker.html

[Chris Dumez]

(In reply to Anne van Kesteren from comment #0)
> Tests:
> 
>   https://w3c-test.org/url/interfaces.any.html
>   https://w3c-test.org/url/interfaces.any.worker.html

Hmm, when I import this test locally, I get:
Harness Error (FAIL), message = Unterminated generic type record, line 20 (tokens: ', USVString> ')
[
    {
        "type": "other",
        "value": ","
    },
    {
        "type": "whitespace",
        "value": " "
    },
    {
        "type": "identifier",
        "value": "USVString"
    },
    {
        "type": "other",
        "value": ">"
    },
    {
        "type": "whitespace",
        "value": " "
    }
]

PASS Untitled


It is running fine on w3c-test.org though :/ I tried updating our idlharness.js but it did not help.

[Chris Dumez]

Created attachment 310431 [details]
WIP Patch

[Build Bot]

Comment on attachment 310431 [details]
WIP Patch

Attachment 310431 [details] did not pass bindings-ews (mac):
Output: http://webkit-queues.webkit.org/results/3764419

New failing tests:
(JS) JSTestIterable.cpp
(JS) JSMapLike.cpp
(JS) JSTestNode.cpp
(JS) JSReadOnlyMapLike.cpp

[Build Bot]

Comment on attachment 310431 [details]
WIP Patch

Attachment 310431 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3764525

New failing tests:
fast/text/unicode-range-javascript.html

[Build Bot]

Created attachment 310437 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310431 [details]
WIP Patch

Attachment 310431 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3764537

New failing tests:
imported/w3c/web-platform-tests/url/a-element-origin-xhtml.xhtml
imported/w3c/web-platform-tests/XMLHttpRequest/interfaces.html
imported/w3c/web-platform-tests/media-source/interfaces.html
imported/w3c/web-platform-tests/url/failure.html
imported/w3c/web-platform-tests/url/a-element-origin.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-idl.html
imported/w3c/web-platform-tests/hr-time/idlharness.html
imported/w3c/web-platform-tests/encoding/idlharness.html
imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.html
imported/w3c/web-platform-tests/url/url-origin.html
imported/w3c/web-platform-tests/fetch/api/request/request-idl.html
imported/w3c/web-platform-tests/FileAPI/idlharness.worker.html
imported/w3c/web-platform-tests/fetch/api/response/response-idl.html
imported/w3c/web-platform-tests/url/url-constructor.html
imported/w3c/web-platform-tests/url/a-element-xhtml.xhtml
imported/w3c/web-platform-tests/IndexedDB/interfaces.worker.html
imported/w3c/web-platform-tests/resource-timing/idlharness.html
imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.worker.html
imported/w3c/web-platform-tests/background-fetch/interfaces.worker.html
imported/w3c/web-platform-tests/url/historical.worker.html
imported/w3c/web-platform-tests/IndexedDB/interfaces.html
imported/w3c/web-platform-tests/notifications/interfaces.html
fast/text/unicode-range-javascript.html
imported/w3c/web-platform-tests/url/a-element.html
imported/w3c/web-platform-tests/FileAPI/idlharness.html
imported/w3c/web-platform-tests/url/urlsearchparams-constructor.html

[Build Bot]

Created attachment 310444 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310431 [details]
WIP Patch

Attachment 310431 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3764574

New failing tests:
fast/text/unicode-range-javascript.html

[Build Bot]

Created attachment 310445 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310431 [details]
WIP Patch

Attachment 310431 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3764824

New failing tests:
imported/w3c/web-platform-tests/url/a-element-origin-xhtml.xhtml
imported/w3c/web-platform-tests/XMLHttpRequest/interfaces.html
imported/w3c/web-platform-tests/media-source/interfaces.html
imported/w3c/web-platform-tests/url/failure.html
imported/w3c/web-platform-tests/url/a-element-origin.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-idl.html
imported/w3c/web-platform-tests/hr-time/idlharness.html
imported/w3c/web-platform-tests/encoding/idlharness.html
imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.html
imported/w3c/web-platform-tests/url/url-origin.html
imported/w3c/web-platform-tests/fetch/api/request/request-idl.html
imported/w3c/web-platform-tests/FileAPI/idlharness.worker.html
imported/w3c/web-platform-tests/fetch/api/response/response-idl.html
imported/w3c/web-platform-tests/url/url-constructor.html
imported/w3c/web-platform-tests/url/a-element-xhtml.xhtml
imported/w3c/web-platform-tests/IndexedDB/interfaces.worker.html
imported/w3c/web-platform-tests/dom/interfaces.html
imported/w3c/web-platform-tests/resource-timing/idlharness.html
imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.worker.html
imported/w3c/web-platform-tests/background-fetch/interfaces.worker.html
imported/w3c/web-platform-tests/url/historical.worker.html
imported/w3c/web-platform-tests/IndexedDB/interfaces.html
imported/w3c/web-platform-tests/notifications/interfaces.html
fast/text/unicode-range-javascript.html
imported/w3c/web-platform-tests/url/a-element.html
imported/w3c/web-platform-tests/FileAPI/idlharness.html
imported/w3c/web-platform-tests/url/urlsearchparams-constructor.html

[Build Bot]

Created attachment 310448 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Chris Dumez]

(In reply to Chris Dumez from comment #1)
> (In reply to Anne van Kesteren from comment #0)
> > Tests:
> > 
> >   https://w3c-test.org/url/interfaces.any.html
> >   https://w3c-test.org/url/interfaces.any.worker.html
> 
> Hmm, when I import this test locally, I get:
> Harness Error (FAIL), message = Unterminated generic type record, line 20
> (tokens: ', USVString> ')
> [
>     {
>         "type": "other",
>         "value": ","
>     },
>     {
>         "type": "whitespace",
>         "value": " "
>     },
>     {
>         "type": "identifier",
>         "value": "USVString"
>     },
>     {
>         "type": "other",
>         "value": ">"
>     },
>     {
>         "type": "whitespace",
>         "value": " "
>     }
> ]
> 
> PASS Untitled
> 
> 
> It is running fine on w3c-test.org though :/ I tried updating our
> idlharness.js but it did not help.

Tentatively re-syncing our WPT tools via Bug 172247 in hope that it addresses this issue.

[Chris Dumez]

Created attachment 310605 [details]
WIP Patch

[Chris Dumez]

Created attachment 310606 [details]
WIP Patch

[Build Bot]

Comment on attachment 310606 [details]
WIP Patch

Attachment 310606 [details] did not pass bindings-ews (mac):
Output: http://webkit-queues.webkit.org/results/3773846

New failing tests:
(JS) JSTestIterable.cpp
(JS) JSMapLike.cpp
(JS) JSTestNode.cpp
(JS) JSReadOnlyMapLike.cpp

[Chris Dumez]

(In reply to Chris Dumez from comment #1)
> (In reply to Anne van Kesteren from comment #0)
> > Tests:
> > 
> >   https://w3c-test.org/url/interfaces.any.html
> >   https://w3c-test.org/url/interfaces.any.worker.html
> 
> Hmm, when I import this test locally, I get:
> Harness Error (FAIL), message = Unterminated generic type record, line 20
> (tokens: ', USVString> ')
> [
>     {
>         "type": "other",
>         "value": ","
>     },
>     {
>         "type": "whitespace",
>         "value": " "
>     },
>     {
>         "type": "identifier",
>         "value": "USVString"
>     },
>     {
>         "type": "other",
>         "value": ">"
>     },
>     {
>         "type": "whitespace",
>         "value": " "
>     }
> ]
> 
> PASS Untitled
> 
> 
> It is running fine on w3c-test.org though :/ I tried updating our
> idlharness.js but it did not help.

Found the issue. It is webbidl2.js that is outdated. Updating it via Bug 172342.

[Build Bot]

Comment on attachment 310606 [details]
WIP Patch

Attachment 310606 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3773931

New failing tests:
fast/text/unicode-range-javascript.html

[Build Bot]

Created attachment 310620 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310606 [details]
WIP Patch

Attachment 310606 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3774004

New failing tests:
fast/text/unicode-range-javascript.html

[Build Bot]

Created attachment 310621 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310606 [details]
WIP Patch

Attachment 310606 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3774007

New failing tests:
fast/text/unicode-range-javascript.html

[Build Bot]

Created attachment 310622 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310606 [details]
WIP Patch

Attachment 310606 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3774041

New failing tests:
fast/text/unicode-range-javascript.html

[Build Bot]

Created attachment 310623 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Chris Dumez]

Created attachment 310701 [details]
Patch

[youenn fablet]

Comment on attachment 310701 [details]
Patch

Looks better indeed!
Might want to do some additional clean-up, see below.
Maybe we do not need to add Symbol.Iterator at all in IDLParser.pm and handle it directly in CodeGeneratorJS.pm

View in context: https://bugs.webkit.org/attachment.cgi?id=310701&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:5439
> +            $iterationKind = "Value" if $propertyName eq "entries" and not $interface->iterable->isKeyValue;

We should not need to do anything with Symbol.Iterator here since we are reusing entries or values for that.
We are generating code for nothing probably. Can we remove that case?
Probably also for these function declarations as well.

> Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp:300
>  

Yep, jsTestNodePrototypeFunctionSymbolIterator is probably not needed.

[Chris Dumez]

Created attachment 310709 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 310709 [details]
Patch

Clearing flags on attachment: 310709

Committed r217166: <http://trac.webkit.org/changeset/217166>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.