Bug 172217 - Regression (198943): <marquee> shouldn't wrap text
Summary: Regression (198943): <marquee> shouldn't wrap text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-17 06:01 PDT by Antti Koivisto
Modified: 2017-05-17 08:12 PDT (History)
3 users (show)

See Also:

Attachments
patch (5.91 KB, patch)
2017-05-17 06:15 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-05-17 06:01:13 PDT 
<marquee><span>text</span></marquee> should render the text in single line.
Comment 1 Antti Koivisto 2017-05-17 06:15:58 PDT 
Created attachment 310385 [details]
patch
Comment 2 Antti Koivisto 2017-05-17 07:21:09 PDT 
<rdar://problem/31812669>
Comment 3 Andreas Kling 2017-05-17 07:25:39 PDT 
Comment on attachment 310385 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310385&action=review

Wow, I was not expecting to see a marquee patch in 2017. r=me

> Source/WebCore/rendering/RenderMarquee.cpp:200
> -    auto& style = m_layer->renderer().mutableStyle();
> +    auto& style = m_layer->renderer().style();

Nice.
Comment 4 WebKit Commit Bot 2017-05-17 08:12:52 PDT 
Comment on attachment 310385 [details]
patch

Clearing flags on attachment: 310385

Committed r216973: <http://trac.webkit.org/changeset/216973>
Comment 5 WebKit Commit Bot 2017-05-17 08:12:53 PDT 
All reviewed patches have been landed.  Closing bug.