WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172214
More WebKit2 header cleanup
https://bugs.webkit.org/show_bug.cgi?id=172214
Summary
More WebKit2 header cleanup
Tim Horton
Reported
2017-05-17 02:18:38 PDT
More WebKit2 haeader cleanup
Attachments
Patch
(34.69 KB, patch)
2017-05-17 02:19 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Patch
(38.94 KB, patch)
2017-05-17 02:49 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews101 for mac-elcapitan
(1.10 MB, application/zip)
2017-05-17 09:07 PDT
,
Build Bot
no flags
Details
Patch
(42.71 KB, patch)
2017-05-18 01:30 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2017-05-17 02:19:59 PDT
Created
attachment 310363
[details]
Patch
Build Bot
Comment 2
2017-05-17 02:22:49 PDT
Attachment 310363
[details]
did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3
2017-05-17 02:49:07 PDT
Created
attachment 310364
[details]
Patch
Tim Horton
Comment 4
2017-05-17 02:49:28 PDT
This will probably take a few rounds to get building on all the ports I haven't tested.
Tim Horton
Comment 5
2017-05-17 02:50:50 PDT
Comment on
attachment 310364
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=310364&action=review
> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1691 > - if (m_findController.isShowingOverlay()) { > + if (m_findController->isShowingOverlay()) {
I wonder if people would prefer to use the (inlinable) findController() method instead so that we can still use dot syntax and don't have to worry about whether it can be null (too bad UniqueRef can't make dot work :( )
Build Bot
Comment 6
2017-05-17 09:07:20 PDT
Comment on
attachment 310364
[details]
Patch
Attachment 310364
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/3763213
New failing tests: http/tests/appcache/404-resource-with-slow-main-resource.php
Build Bot
Comment 7
2017-05-17 09:07:21 PDT
Created
attachment 310395
[details]
Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Simon Fraser (smfr)
Comment 8
2017-05-17 12:52:32 PDT
Comment on
attachment 310364
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=310364&action=review
>> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1691 >> + if (m_findController->isShowingOverlay()) { > > I wonder if people would prefer to use the (inlinable) findController() method instead so that we can still use dot syntax and don't have to worry about whether it can be null (too bad UniqueRef can't make dot work :( )
Yes.
Tim Horton
Comment 9
2017-05-18 01:30:13 PDT
Created
attachment 310499
[details]
Patch
Tim Horton
Comment 10
2017-05-18 02:04:44 PDT
http://trac.webkit.org/changeset/217041/webkit
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug