Bug 172213 - Speedometer: check-in missing React TodoMVC dependency
Summary: Speedometer: check-in missing React TodoMVC dependency
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Addy Osmani
URL:
Keywords:
Depends on:
Blocks: 170513
  Show dependency treegraph
 
Reported: 2017-05-17 01:57 PDT by Addy Osmani
Modified: 2017-05-18 20:03 PDT (History)
6 users (show)

See Also:


Attachments
Patch (33.94 KB, patch)
2017-05-17 02:00 PDT, Addy Osmani
no flags Details | Formatted Diff | Diff
Patch (2.58 KB, patch)
2017-05-17 09:46 PDT, Addy Osmani
no flags Details | Formatted Diff | Diff
Patch (12.15 KB, patch)
2017-05-18 17:46 PDT, Addy Osmani
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Addy Osmani 2017-05-17 01:57:23 PDT
Missing director.js dependencies must be added back in.
Comment 1 Addy Osmani 2017-05-17 02:00:09 PDT
Created attachment 310361 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2017-05-17 04:32:48 PDT
Comment on attachment 310361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310361&action=review

r=me, but consider using director.min.js.

> PerformanceTests/Speedometer/resources/todomvc/architecture-examples/react/index.html:17
> +    <script src="node_modules/director/director.js"></script>

Don't you want to use director.min.js here to match other resources?
Comment 3 Addy Osmani 2017-05-17 09:46:13 PDT
Created attachment 310401 [details]
Patch
Comment 4 David Kilzer (:ddkilzer) 2017-05-17 11:28:06 PDT
Comment on attachment 310401 [details]
Patch

Missing the added files, so the ChangeLog entry is wrong.
Comment 5 David Kilzer (:ddkilzer) 2017-05-17 12:59:44 PDT
(In reply to David Kilzer (:ddkilzer) from comment #4)
> Comment on attachment 310401 [details]
> Patch
> 
> Missing the added files, so the ChangeLog entry is wrong.

And I assume you want to add the files still?
Comment 6 Addy Osmani 2017-05-18 17:29:27 PDT
Yes. Please excuse the missing file - unsure what is dropping `build` directories locally (checked gitignores). I'm going to update this and double check the dependency is definitely in there.
Comment 7 Addy Osmani 2017-05-18 17:46:11 PDT
Created attachment 310582 [details]
Patch
Comment 8 Ryosuke Niwa 2017-05-18 19:52:50 PDT
Comment on attachment 310582 [details]
Patch

r=me.
Comment 9 Ryosuke Niwa 2017-05-18 20:03:56 PDT
Comment on attachment 310582 [details]
Patch

Clearing flags on attachment: 310582

Committed r217088: <http://trac.webkit.org/changeset/217088>
Comment 10 Ryosuke Niwa 2017-05-18 20:03:58 PDT
All reviewed patches have been landed.  Closing bug.