Bug 17218 - Metrics pane should be editable
Summary: Metrics pane should be editable
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Timothy Hatcher
Keywords: InRadar
Depends on:
Reported: 2008-02-08 13:38 PST by Adam Roben (:aroben)
Modified: 2008-08-21 13:14 PDT (History)
1 user (show)

See Also:

Proposed patch (9.42 KB, patch)
2008-08-20 16:01 PDT, Timothy Hatcher
kmccullough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2008-02-08 13:38:10 PST
You should be able to edit an element's metrics directly in the Metrics pane. Firebug does this by letting you double-click on any of the numbers in the Metrics pane.
Comment 1 Adam Roben (:aroben) 2008-02-08 14:15:57 PST
Comment 2 Timothy Hatcher 2008-08-20 16:01:12 PDT
Created attachment 22906 [details]
Proposed patch
Comment 3 Kevin McCullough 2008-08-21 10:44:24 PDT
Comment on attachment 22906 [details]
Proposed patch

does editingCancelled need a context?
Comment 4 Timothy Hatcher 2008-08-21 12:55:18 PDT
(In reply to comment #3)
> (From update of attachment 22906 [details] [edit])
> does editingCancelled need a context?

The shared editing code calls editingCancelled and passes a context. We don't use it, but it is always passed to us.
Comment 5 Timothy Hatcher 2008-08-21 13:14:55 PDT
Landed fix in r35876.