Bug 172174 - Tighten TextIterator::handleTextNode run-renderer mapping logic.
Summary: Tighten TextIterator::handleTextNode run-renderer mapping logic.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-16 10:09 PDT by zalan
Modified: 2017-05-17 17:29 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.47 KB, patch)
2017-05-16 10:20 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (3.52 KB, patch)
2017-05-16 10:39 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (403.67 KB, application/zip)
2017-05-16 11:04 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.32 MB, application/zip)
2017-05-16 11:28 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (309.02 KB, application/zip)
2017-05-16 11:32 PDT, Build Bot
no flags Details
Patch (6.95 KB, patch)
2017-05-16 20:36 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (6.52 KB, patch)
2017-05-17 08:08 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-02 for mac-elcapitan (986.67 KB, application/zip)
2017-05-17 11:14 PDT, WebKit Commit Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-05-16 10:09:22 PDT
and bail out of we are out of sync.
Comment 1 zalan 2017-05-16 10:20:26 PDT
Created attachment 310271 [details]
Patch
Comment 2 Antti Koivisto 2017-05-16 10:23:04 PDT
Comment on attachment 310271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310271&action=review

> Source/WebCore/editing/TextIterator.cpp:656
> +        // If the position we are looking for is to the left of the renderer's first run, it means that
> +        // the runs and the renderers are out of sync (e.g. we skipped a renderer in between).
> +        // Better bail out at this point.

Should we have an assert for this?
Comment 3 zalan 2017-05-16 10:39:03 PDT
Created attachment 310272 [details]
Patch
Comment 4 Build Bot 2017-05-16 11:04:33 PDT
Comment on attachment 310272 [details]
Patch

Attachment 310272 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3751634

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2017-05-16 11:04:34 PDT
Created attachment 310277 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-05-16 11:28:39 PDT
Comment on attachment 310272 [details]
Patch

Attachment 310272 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3751742

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2017-05-16 11:28:40 PDT
Created attachment 310281 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-05-16 11:32:04 PDT
Comment on attachment 310272 [details]
Patch

Attachment 310272 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3751778

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2017-05-16 11:32:05 PDT
Created attachment 310283 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 10 zalan 2017-05-16 20:36:59 PDT
Created attachment 310346 [details]
Patch
Comment 11 WebKit Commit Bot 2017-05-17 07:11:04 PDT
Comment on attachment 310346 [details]
Patch

Rejecting attachment 310346 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 310346, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ore/rendering/SimpleLineLayoutFunctions.cpp
patching file Source/WebCore/rendering/SimpleLineLayoutFunctions.h
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/shadow-dom/slot-crash-expected.txt
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/fast/shadow-dom/slot-crash-expected.txt.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3762833
Comment 12 zalan 2017-05-17 08:08:19 PDT
Created attachment 310391 [details]
Patch
Comment 13 WebKit Commit Bot 2017-05-17 11:14:10 PDT
Comment on attachment 310391 [details]
Patch

Rejecting attachment 310391 [details] from commit-queue.

New failing tests:
http/tests/media/hls/video-duration-accessibility.html
http/tests/appcache/404-resource-with-slow-main-resource.php
Full output: http://webkit-queues.webkit.org/results/3763806
Comment 14 WebKit Commit Bot 2017-05-17 11:14:12 PDT
Created attachment 310412 [details]
Archive of layout-test-results from webkit-cq-02 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 15 zalan 2017-05-17 14:31:36 PDT
(In reply to WebKit Commit Bot from comment #13)
> Comment on attachment 310391 [details]
> Patch
> 
> Rejecting attachment 310391 [details] from commit-queue.
> 
> New failing tests:
> http/tests/media/hls/video-duration-accessibility.html
> http/tests/appcache/404-resource-with-slow-main-resource.php
> Full output: http://webkit-queues.webkit.org/results/3763806
They look unrelated.
Comment 16 WebKit Commit Bot 2017-05-17 17:29:10 PDT
Comment on attachment 310391 [details]
Patch

Clearing flags on attachment: 310391

Committed r217019: <http://trac.webkit.org/changeset/217019>
Comment 17 WebKit Commit Bot 2017-05-17 17:29:12 PDT
All reviewed patches have been landed.  Closing bug.