Bug 172173 - Allow nested timers to propagate user gestures so long as the total nested interval is less than 1s.
Summary: Allow nested timers to propagate user gestures so long as the total nested in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
: 171671 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-05-16 10:06 PDT by Jer Noble
Modified: 2017-05-18 13:32 PDT (History)
8 users (show)

See Also:


Attachments
Patch (11.32 KB, patch)
2017-05-16 10:12 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-elcapitan (955.64 KB, application/zip)
2017-05-16 11:26 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (930.04 KB, application/zip)
2017-05-16 11:31 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.73 MB, application/zip)
2017-05-16 11:39 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (31.84 MB, application/zip)
2017-05-16 11:47 PDT, Build Bot
no flags Details
Patch (15.34 KB, patch)
2017-05-17 15:57 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (17.80 MB, application/zip)
2017-05-17 17:45 PDT, Build Bot
no flags Details
Patch (16.16 KB, patch)
2017-05-17 21:39 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (51.23 KB, patch)
2017-05-18 12:47 PDT, Jer Noble
jer.noble: commit-queue+
Details | Formatted Diff | Diff
Patch for landing (15.92 KB, patch)
2017-05-18 12:51 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-05-16 10:06:28 PDT
Allow nested timers to propagate user gestures so long as the total nested interval is less than 1s.
Comment 1 Jer Noble 2017-05-16 10:12:00 PDT
Created attachment 310268 [details]
Patch
Comment 2 Build Bot 2017-05-16 11:26:41 PDT
Comment on attachment 310268 [details]
Patch

Attachment 310268 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3751648

New failing tests:
fast/events/popup-blocking-timers4.html
fast/events/popup-blocked-from-untrusted-mouse-click.html
Comment 3 Build Bot 2017-05-16 11:26:42 PDT
Created attachment 310280 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-05-16 11:31:27 PDT
Comment on attachment 310268 [details]
Patch

Attachment 310268 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3751663

New failing tests:
fast/events/popup-blocking-timers4.html
fast/events/popup-blocked-from-untrusted-mouse-click.html
Comment 5 Build Bot 2017-05-16 11:31:28 PDT
Created attachment 310282 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-05-16 11:39:27 PDT
Comment on attachment 310268 [details]
Patch

Attachment 310268 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3751675

New failing tests:
fast/events/popup-blocking-timers4.html
fast/events/popup-blocked-from-untrusted-mouse-click.html
Comment 7 Build Bot 2017-05-16 11:39:29 PDT
Created attachment 310285 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-05-16 11:47:51 PDT
Comment on attachment 310268 [details]
Patch

Attachment 310268 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3751623

New failing tests:
media/restricted-audio-playback-with-multiple-settimeouts.html
Comment 9 Build Bot 2017-05-16 11:47:53 PDT
Created attachment 310287 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 Jon Lee 2017-05-16 22:33:06 PDT
rdar://problem/31991224
Comment 11 Jon Lee 2017-05-17 09:18:34 PDT
*** Bug 171671 has been marked as a duplicate of this bug. ***
Comment 12 Jer Noble 2017-05-17 15:57:35 PDT
Created attachment 310454 [details]
Patch
Comment 13 Build Bot 2017-05-17 17:45:39 PDT
Comment on attachment 310454 [details]
Patch

Attachment 310454 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3765535

New failing tests:
media/restricted-audio-playback-with-multiple-settimeouts.html
Comment 14 Build Bot 2017-05-17 17:45:41 PDT
Created attachment 310470 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 15 Jer Noble 2017-05-17 21:39:57 PDT
Created attachment 310487 [details]
Patch
Comment 16 Eric Carlson 2017-05-18 07:18:47 PDT
Comment on attachment 310487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310487&action=review

> LayoutTests/fast/events/popup-blocked-from-untrusted-mouse-click.html:39
> +function waitAWhile(milliseconds) {
> +    return new Promise(resolve => { setTimeout(resolve, milliseconds) });
> +}
> +

Doesn't look like this is used.
Comment 17 Jer Noble 2017-05-18 11:49:07 PDT
(In reply to Eric Carlson from comment #16)
> Comment on attachment 310487 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310487&action=review
> 
> > LayoutTests/fast/events/popup-blocked-from-untrusted-mouse-click.html:39
> > +function waitAWhile(milliseconds) {
> > +    return new Promise(resolve => { setTimeout(resolve, milliseconds) });
> > +}
> > +
> 
> Doesn't look like this is used.

Good catch; I'll remove it.
Comment 18 Andy Estes 2017-05-18 11:58:53 PDT
Comment on attachment 310487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310487&action=review

> Source/WebCore/page/DOMTimer.cpp:61
> -    explicit DOMTimerFireState(ScriptExecutionContext& context)
> +    explicit DOMTimerFireState(ScriptExecutionContext& context, int nestingLevel, const Seconds& nestedTimerInterval)

This doesn't need to be marked explicit anymore.
Comment 19 Jer Noble 2017-05-18 12:47:43 PDT
Created attachment 310534 [details]
Patch for landing
Comment 20 Jer Noble 2017-05-18 12:51:33 PDT
Created attachment 310535 [details]
Patch for landing
Comment 21 WebKit Commit Bot 2017-05-18 13:32:04 PDT
Comment on attachment 310535 [details]
Patch for landing

Clearing flags on attachment: 310535

Committed r217063: <http://trac.webkit.org/changeset/217063>
Comment 22 WebKit Commit Bot 2017-05-18 13:32:06 PDT
All reviewed patches have been landed.  Closing bug.