Bug 17217 - add COMPILE_ASSERT(sizeof(Foo) == 32) for classes we're trying to keep small
Summary: add COMPILE_ASSERT(sizeof(Foo) == 32) for classes we're trying to keep small
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: EasyFix
Depends on: 55088
Blocks:
  Show dependency tree / graph
 
Reported: 2008-02-08 12:56 PST by Eric Seidel (no email)
Modified: 2019-08-07 12:13 PDT (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-02-08 12:56:46 PST 
add COMPILE_ASSERT(sizeof(Foo) == 32) for classes we're trying to keep small

Now that we have these magical COMPILE_ASSERTs we should use them to make sure we don't accidentally inflate core classes with changes.
Comment 1 David Kilzer (:ddkilzer) 2019-08-07 11:28:27 PDT 
Simon or Alan:  Is there anything actionable here?  Eric didn't list specific classes when he filed this, so I'm not sure which ones he was thinking of.
Comment 2 Simon Fraser (smfr) 2019-08-07 11:38:11 PDT 
Nah.
Comment 3 Yusuke Suzuki 2019-08-07 12:13:16 PDT 
I don't think this bug itself is actionable.
But, note that we are already doing this thing for some of super important classes (in particular in JSC).
e.g. https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp#L47