RESOLVED WONTFIX 17217
add COMPILE_ASSERT(sizeof(Foo) == 32) for classes we're trying to keep small 
https://bugs.webkit.org/show_bug.cgi?id=17217
Summary add COMPILE_ASSERT(sizeof(Foo) == 32) for classes we're trying to keep small
Eric Seidel (no email)
Reported 2008-02-08 12:56:46 PST
add COMPILE_ASSERT(sizeof(Foo) == 32) for classes we're trying to keep small Now that we have these magical COMPILE_ASSERTs we should use them to make sure we don't accidentally inflate core classes with changes.
Attachments
Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2019-08-07 11:28:27 PDT
Simon or Alan: Is there anything actionable here? Eric didn't list specific classes when he filed this, so I'm not sure which ones he was thinking of.
Simon Fraser (smfr)
Comment 2 2019-08-07 11:38:11 PDT
Nah.
Yusuke Suzuki
Comment 3 2019-08-07 12:13:16 PDT
I don't think this bug itself is actionable. But, note that we are already doing this thing for some of super important classes (in particular in JSC). e.g. https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp#L47
Note You need to log in before you can comment on or make changes to this bug.