RESOLVED FIXED172162
[WPE] GLContextEGL::createWPEContext() should fall back to pbuffer-based contexts when offscreen target provides no native window 
https://bugs.webkit.org/show_bug.cgi?id=172162
Summary [WPE] GLContextEGL::createWPEContext() should fall back to pbuffer-based cont...
Zan Dobersek
Reported 2017-05-15 23:09:34 PDT
[WPE] GLContextEGL::createWPEContext() should fall back to pbuffer-based contexts when offscreen target provides no native window
Attachments
Patch (2.21 KB, patch)
2017-05-15 23:11 PDT, Zan Dobersek 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-05-15 23:11:20 PDT
Created attachment 310231 [details] Patch
Carlos Garcia Campos
Comment 2 2017-05-16 01:00:45 PDT
Comment on attachment 310231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310231&action=review > Source/WebCore/platform/graphics/egl/GLContextEGLWPE.cpp:36 > + if (!context) > + context = createPbufferContext(platformDisplay, sharingContext); Why not falling back to a surfaceless context if available?
Zan Dobersek
Comment 3 2017-05-16 05:48:03 PDT
(In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 310231 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=310231&action=review > > > Source/WebCore/platform/graphics/egl/GLContextEGLWPE.cpp:36 > > + if (!context) > > + context = createPbufferContext(platformDisplay, sharingContext); > > Why not falling back to a surfaceless context if available? I'll look into it. Will add a FIXME until then.
Zan Dobersek
Comment 4 2017-05-16 06:04:33 PDT
Committed r216930: <http://trac.webkit.org/changeset/216930>
Note You need to log in before you can comment on or make changes to this bug.