Bug 172162 - [WPE] GLContextEGL::createWPEContext() should fall back to pbuffer-based contexts when offscreen target provides no native window
Summary: [WPE] GLContextEGL::createWPEContext() should fall back to pbuffer-based cont...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-15 23:09 PDT by Zan Dobersek
Modified: 2017-05-16 06:04 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.21 KB, patch)
2017-05-15 23:11 PDT, Zan Dobersek 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-05-15 23:09:34 PDT 
[WPE] GLContextEGL::createWPEContext() should fall back to pbuffer-based contexts when offscreen target provides no native window
Comment 1 Zan Dobersek 2017-05-15 23:11:20 PDT 
Created attachment 310231 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-05-16 01:00:45 PDT 
Comment on attachment 310231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310231&action=review

> Source/WebCore/platform/graphics/egl/GLContextEGLWPE.cpp:36
> +    if (!context)
> +        context = createPbufferContext(platformDisplay, sharingContext);

Why not falling back to a surfaceless context if available?
Comment 3 Zan Dobersek 2017-05-16 05:48:03 PDT 
(In reply to Carlos Garcia Campos from comment #2)
> Comment on attachment 310231 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310231&action=review
> 
> > Source/WebCore/platform/graphics/egl/GLContextEGLWPE.cpp:36
> > +    if (!context)
> > +        context = createPbufferContext(platformDisplay, sharingContext);
> 
> Why not falling back to a surfaceless context if available?

I'll look into it. Will add a FIXME until then.
Comment 4 Zan Dobersek 2017-05-16 06:04:33 PDT 
Committed r216930: <http://trac.webkit.org/changeset/216930>