Bug 172157 - [WK2][macOS] Support Flash Player DRM features
Summary: [WK2][macOS] Support Flash Player DRM features
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-15 21:49 PDT by Brent Fulgham
Modified: 2017-06-07 16:49 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2017-05-15 21:51 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-05-15 21:49:31 PDT
Certain Flash-based media players have DRM that require access to additional IOKit property.

This patch weakens the PluginProcess sandbox to support these DRM features.
Comment 1 Brent Fulgham 2017-05-15 21:50:22 PDT
<rdar://problem/31889297>
Comment 2 Brent Fulgham 2017-05-15 21:51:51 PDT
Created attachment 310222 [details]
Patch
Comment 3 WebKit Commit Bot 2017-05-16 12:54:49 PDT
Comment on attachment 310222 [details]
Patch

Clearing flags on attachment: 310222

Committed r216943: <http://trac.webkit.org/changeset/216943>
Comment 4 WebKit Commit Bot 2017-05-16 12:54:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 mitz 2017-05-16 13:02:34 PDT
Comment on attachment 310222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310222&action=review

> Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:68
> +    (iokit-property "IOMACAddress") ;; For some Flash players
> +    (iokit-property "IOPlatformSerialNumber") ;; Ditto

I wonder why things that are needed for specific plug-ins cannot be in the sandbox profiles for those specific plug-ins, such as com.macromedia.Flash Player.plugin.sb and com.macromedia.Flash Player ESR.plugin.sb.
Comment 6 Brent Fulgham 2017-05-16 13:30:45 PDT
(In reply to mitz from comment #5)
> Comment on attachment 310222 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310222&action=review
> 
> > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:68
> > +    (iokit-property "IOMACAddress") ;; For some Flash players
> > +    (iokit-property "IOPlatformSerialNumber") ;; Ditto
> 
> I wonder why things that are needed for specific plug-ins cannot be in the
> sandbox profiles for those specific plug-ins, such as com.macromedia.Flash
> Player.plugin.sb and com.macromedia.Flash Player ESR.plugin.sb.

They definitely could be done at a lower level. Once some internal discussions are complete, we may decide to narrow the scope of these properties to specific plugins only.

Ultimately, of course, the goal is to get rid of plugins entirely.