WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172149
Make it possible to adjust which edges are affected by safe area insets
https://bugs.webkit.org/show_bug.cgi?id=172149
Summary
Make it possible to adjust which edges are affected by safe area insets
Tim Horton
Reported
2017-05-15 17:30:24 PDT
Make it possible to adjust which edges are affected by safe area insets
Attachments
Patch
(6.30 KB, patch)
2017-05-15 17:31 PDT
,
Tim Horton
bdakin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2017-05-15 17:31:26 PDT
Created
attachment 310194
[details]
Patch
Sam Weinig
Comment 2
2017-05-15 19:28:15 PDT
Comment on
attachment 310194
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=310194&action=review
> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:160 > @property (nonatomic, readonly) BOOL _safeAreaShouldAffectObscuredInsets WK_API_AVAILABLE(ios(WK_IOS_TBA)); > +@property (nonatomic, setter=_setObscuredInsetEdgesAffectedBySafeArea:) UIRectEdge _obscuredInsetEdgesAffectedBySafeArea WK_API_AVAILABLE(ios(WK_IOS_TBA));
Does it make sense to have both of these? Since you could just set _obscuredInsetEdgesAffectedBySafeArea to UIRectEdgeNone. Or does _safeAreaShouldAffectObscuredInsets do more than that?
Tim Horton
Comment 3
2017-05-16 00:36:39 PDT
(In reply to Sam Weinig from
comment #2
)
> Comment on
attachment 310194
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=310194&action=review
> > > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:160 > > @property (nonatomic, readonly) BOOL _safeAreaShouldAffectObscuredInsets WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > +@property (nonatomic, setter=_setObscuredInsetEdgesAffectedBySafeArea:) UIRectEdge _obscuredInsetEdgesAffectedBySafeArea WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > Does it make sense to have both of these? Since you could just set > _obscuredInsetEdgesAffectedBySafeArea to UIRectEdgeNone. Or does > _safeAreaShouldAffectObscuredInsets do more than that?
Please note that _safeAreaShouldAffectObscuredInsets is read-only. It exposes the intent of the page, not of the API client.
Tim Horton
Comment 4
2017-05-16 10:21:02 PDT
http://trac.webkit.org/changeset/216935/webkit
Sam Weinig
Comment 5
2017-05-16 10:37:55 PDT
(In reply to Tim Horton from
comment #3
)
> (In reply to Sam Weinig from
comment #2
) > > Comment on
attachment 310194
[details]
> > Patch > > > > View in context: > >
https://bugs.webkit.org/attachment.cgi?id=310194&action=review
> > > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:160 > > > @property (nonatomic, readonly) BOOL _safeAreaShouldAffectObscuredInsets WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > > +@property (nonatomic, setter=_setObscuredInsetEdgesAffectedBySafeArea:) UIRectEdge _obscuredInsetEdgesAffectedBySafeArea WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > > > Does it make sense to have both of these? Since you could just set > > _obscuredInsetEdgesAffectedBySafeArea to UIRectEdgeNone. Or does > > _safeAreaShouldAffectObscuredInsets do more than that? > > Please note that _safeAreaShouldAffectObscuredInsets is read-only. It > exposes the intent of the page, not of the API client.
Ah. These are some tricky names to wrap ones head around :(.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug