RESOLVED FIXED 172135
Web Inspector: CRASH seen with DOM.setOuterHTML when there is no documentElement 
https://bugs.webkit.org/show_bug.cgi?id=172135
Summary Web Inspector: CRASH seen with DOM.setOuterHTML when there is no documentElement
Joseph Pecoraro
Reported 2017-05-15 14:30:23 PDT
Summary: CRASH seen with DOM.setOuterHTML when there is no documentElement Steps to Reproduce 1. Inspect this page 2. js> document.documentElement.remove() 3. Open inspector² 4. js> DOMAgent.setOuterHTML(1, "Test") => CRASH Notes: Not exactly sure how to reproduce this outside of sending the raw commands, but it shouldn't be possible. to cause a crash no matter the steps.
Attachments
[PATCH] Proposed Fix (3.80 KB, patch)
2017-05-15 14:32 PDT, Joseph Pecoraro 		bburg: review+
DetailsFormatted DiffDiff
[PATCH] For Landing (3.79 KB, patch)
2017-05-15 15:12 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-05-15 14:30:30 PDT
<rdar://problem/32175860>
Joseph Pecoraro
Comment 2 2017-05-15 14:32:08 PDT
Created attachment 310168 [details] [PATCH] Proposed Fix
Blaze Burg
Comment 3 2017-05-15 14:42:07 PDT
Comment on attachment 310168 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=310168&action=review r=me > Source/WebCore/ChangeLog:13 > + Null check the document element whic might not exist. Typo: which
Joseph Pecoraro
Comment 4 2017-05-15 15:12:00 PDT
Created attachment 310174 [details] [PATCH] For Landing
WebKit Commit Bot
Comment 5 2017-05-15 15:32:30 PDT
Comment on attachment 310174 [details] [PATCH] For Landing Clearing flags on attachment: 310174 Committed r216883: <http://trac.webkit.org/changeset/216883>
Note You need to log in before you can comment on or make changes to this bug.