Bug 172131 – Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement

[Jer Noble]

Created attachment 310159 [details]
Patch

[Jer Noble]

Created attachment 310160 [details]
Patch

[Eric Carlson]

Comment on attachment 310159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310159&action=review

> LayoutTests/media/restricted-audio-playback-with-document-gesture.html:11
> +        video = document.getElementsByTagName('audio')[0];

Nit: "video" for an audio element is a bit odd. waitForEvent also works with the global variable "mediaElement" if you don't want to create a video element.

> LayoutTests/media/restricted-audio-playback-with-document-gesture.html:28
> +        run("svideo.play()");

"svideo"?

> LayoutTests/media/restricted-audio-playback-with-document-gesture.html:36
> +    <p>Test that, when RequireUserGestureForAudioRateChange is set alnog with MediaUserGestureInheritsForDocument, a user gesture in the document will allow future media playback requests to succeed.</p>

"alnog"?

[Jer Noble]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 310159 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310159&action=review
> 
> > LayoutTests/media/restricted-audio-playback-with-document-gesture.html:11
> > +        video = document.getElementsByTagName('audio')[0];
> 
> Nit: "video" for an audio element is a bit odd. waitForEvent also works with
> the global variable "mediaElement" if you don't want to create a video
> element.

Some of the methods in video-test.js look for a global 'video' variable to perform operations on.  (I had thought all of them did, but only the "track" related ones seem to.)

> > LayoutTests/media/restricted-audio-playback-with-document-gesture.html:28
> > +        run("svideo.play()");
> 
> "svideo"?

Fixed in an updated version.

> > LayoutTests/media/restricted-audio-playback-with-document-gesture.html:36
> > +    <p>Test that, when RequireUserGestureForAudioRateChange is set alnog with MediaUserGestureInheritsForDocument, a user gesture in the document will allow future media playback requests to succeed.</p>
> 
> "alnog"?

Will fix.

[Jer Noble]

Created attachment 310163 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 310163 [details]
Patch for landing

Rejecting attachment 310163 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 310163, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3746050

[Jer Noble]

Created attachment 310170 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 310170 [details]
Patch for landing

Rejecting attachment 310170 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 310170, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
erencesRefPrivate.h
patching file Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Hunk #1 succeeded at 3120 (offset -1 lines).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/media/restricted-audio-playback-with-document-gesture-expected.txt
patching file LayoutTests/media/restricted-audio-playback-with-document-gesture.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3746254

[Jer Noble]

Created attachment 310173 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 310173 [details]
Patch for landing

Clearing flags on attachment: 310173

Committed r216886: <http://trac.webkit.org/changeset/216886>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/32252791>