Bug 172128 - [WK2][macOS][iOS] Allow Network process to access nsurlstoraged's top level domain data cache
Summary: [WK2][macOS][iOS] Allow Network process to access nsurlstoraged's top level d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-15 10:49 PDT by Brent Fulgham
Modified: 2017-05-15 14:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.16 KB, patch)
2017-05-15 10:58 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-05-15 10:49:16 PDT
We extended the sandbox last cycle to permit access to nsurlstoraged's top level domain data cache. At the time, we believed this was only needed in the WebContent process. However, further logging and feedback from the networking teams reveal that the Network process should also have been granted this access.

This bug allows the Network Process to access the nsurlstoraged's data cache.
Comment 1 Brent Fulgham 2017-05-15 10:51:56 PDT
<rdar://problem/30871490>
Comment 2 Brent Fulgham 2017-05-15 10:58:23 PDT
Created attachment 310149 [details]
Patch
Comment 3 Alex Christensen 2017-05-15 12:19:13 PDT
Is there an explanation about why this is only needed on certain OS versions?  Will this be permanent?  Should we have done it before?
Comment 4 Brent Fulgham 2017-05-15 12:29:17 PDT
(In reply to Alex Christensen from comment #3)
> Is there an explanation about why this is only needed on certain OS
> versions?  Will this be permanent?  Should we have done it before?

It's not needed on older OS's since the cache was not really being used. We want it to be used in an upcoming release, and beyond.
Comment 5 Alex Christensen 2017-05-15 13:53:54 PDT
Comment on attachment 310149 [details]
Patch

In bugzilla I have no comment on the existence of such an upcoming release, much less our plans if such a thing exists.  But r=me
Comment 6 WebKit Commit Bot 2017-05-15 14:22:01 PDT
Comment on attachment 310149 [details]
Patch

Clearing flags on attachment: 310149

Committed r216877: <http://trac.webkit.org/changeset/216877>
Comment 7 WebKit Commit Bot 2017-05-15 14:22:03 PDT
All reviewed patches have been landed.  Closing bug.