Bug 172123 - RealtimeOutgoingVideoSource should support sinkWants for rotation
Summary: RealtimeOutgoingVideoSource should support sinkWants for rotation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-15 09:36 PDT by youenn fablet
Modified: 2017-05-16 14:18 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.13 KB, patch)
2017-05-16 13:30 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-05-15 09:36:27 PDT 
This would ensure rotation is handled even when RTP CVO is not on
Comment 1 Radar WebKit Bug Importer 2017-05-15 10:14:17 PDT 
<rdar://problem/32200017>
Comment 2 youenn fablet 2017-05-16 13:30:09 PDT 
Created attachment 310294 [details]
Patch
Comment 3 Build Bot 2017-05-16 13:32:53 PDT 
Attachment 310294 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/video/i420_buffer.h:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2017-05-16 14:18:23 PDT 
Comment on attachment 310294 [details]
Patch

Clearing flags on attachment: 310294

Committed r216947: <http://trac.webkit.org/changeset/216947>
Comment 5 WebKit Commit Bot 2017-05-16 14:18:24 PDT 
All reviewed patches have been landed.  Closing bug.