Bug 172120 - [ios-simulator] API test WKWebView.ClearAppCache is failing
Summary: [ios-simulator] API test WKWebView.ClearAppCache is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-15 08:59 PDT by Ryan Haddad
Modified: 2017-05-15 12:34 PDT (History)
3 users (show)

See Also:

Attachments
Fix that works for me locally (2.36 KB, patch)
2017-05-15 11:43 PDT, Brady Eidson 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Fix that works for me locally (2.36 KB, patch)
2017-05-15 11:54 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-05-15 08:59:18 PDT 
FAIL WKWebView.ClearAppCache

/Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:161
Value of: -1
Expected: fileSize(dbTargetURL)
Which is: 57344


/Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:162
Value of: -1
Expected: fileSize(walTargetURL)
Which is: 0


/Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:163
Value of: -1
Expected: fileSize(shmTargetURL)
Which is: 32768


/Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:171
Expected: (fileSize(walTargetURL)) > (0), actual: 0 vs 0


/Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:179
Value of: 1ul
  Actual: 1
Expected: websiteDataRecords.count
Which is: 0


/Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:201
Value of: originalWebsiteDataRecordCount - 1
  Actual: 18446744073709551615
Expected: websiteDataRecords.count
Which is: 0

https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/builds/1446
Comment 1 Brady Eidson 2017-05-15 10:55:26 PDT 
As with the same ordeal last week when resolving https://bugs.webkit.org/show_bug.cgi?id=172030, I cannot reproduce locally with the sim.
Comment 2 Brady Eidson 2017-05-15 11:30:05 PDT 
(In reply to Brady Eidson from comment #1)
> As with the same ordeal last week when resolving
> https://bugs.webkit.org/show_bug.cgi?id=172030, I cannot reproduce locally
> with the sim.

That was just the first try.

It's flaky, but does reproduce over half the time.

Looking...
Comment 3 Brady Eidson 2017-05-15 11:37:35 PDT 
Looks like the previous code that explicitly deleted the app cache paths was necessary for the iOS-sim test.

Restoring that seems to fix this.
Comment 4 Brady Eidson 2017-05-15 11:43:38 PDT 
Created attachment 310151 [details]
Fix that works for me locally
Comment 5 WebKit Commit Bot 2017-05-15 11:45:05 PDT 
Comment on attachment 310151 [details]
Fix that works for me locally

Rejecting attachment 310151 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 310151, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3745334
Comment 6 Brady Eidson 2017-05-15 11:54:28 PDT 
Created attachment 310152 [details]
Fix that works for me locally
Comment 7 WebKit Commit Bot 2017-05-15 12:34:32 PDT 
Comment on attachment 310152 [details]
Fix that works for me locally

Clearing flags on attachment: 310152

Committed r216869: <http://trac.webkit.org/changeset/216869>
Comment 8 WebKit Commit Bot 2017-05-15 12:34:34 PDT 
All reviewed patches have been landed.  Closing bug.