Bug 172116 - RenderTheme does not need to be per-page
Summary: RenderTheme does not need to be per-page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-15 06:42 PDT by Antti Koivisto
Modified: 2017-05-15 23:42 PDT (History)
2 users (show)

See Also:


Attachments
patch (37.35 KB, patch)
2017-05-15 07:08 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (40.42 KB, patch)
2017-05-15 07:18 PDT, Antti Koivisto
zalan: review+
Details | Formatted Diff | Diff
patch (40.42 KB, patch)
2017-05-15 10:01 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (41.08 KB, patch)
2017-05-15 11:57 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-05-15 06:42:43 PDT
There are no implementations of RenderTheme::themeForPage that actually care about the page. It can be replaced with a singleton, simplifying a bunch of code.
Comment 1 Antti Koivisto 2017-05-15 06:43:58 PDT
<rdar://problem/30426457>
Comment 2 Antti Koivisto 2017-05-15 07:08:31 PDT
Created attachment 310134 [details]
patch
Comment 3 Antti Koivisto 2017-05-15 07:18:30 PDT
Created attachment 310135 [details]
patch
Comment 4 Antti Koivisto 2017-05-15 10:01:06 PDT
Created attachment 310144 [details]
patch
Comment 5 Antti Koivisto 2017-05-15 11:57:30 PDT
Created attachment 310153 [details]
patch
Comment 6 WebKit Commit Bot 2017-05-15 13:17:04 PDT
Comment on attachment 310153 [details]
patch

Rejecting attachment 310153 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 310153, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ing rebase:
:040000 040000 841e1e2bc57dce4d72bf15c23ee0f9472213b34e 4fc215fbc6e8a33b7011ebfccb90f898a893d471 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/3745756
Comment 7 Antti Koivisto 2017-05-15 22:35:52 PDT
https://trac.webkit.org/r216902