Bug 172106 - AX: Inaccessible content on webkit.org main page
Summary: AX: Inaccessible content on webkit.org main page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 172096
Blocks:
  Show dependency treegraph
 
Reported: 2017-05-15 01:03 PDT by James Craig
Modified: 2017-05-15 14:36 PDT (History)
3 users (show)

See Also:


Attachments
patch (3.92 KB, patch)
2017-05-15 01:13 PDT, James Craig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2017-05-15 01:03:04 PDT
AX: Inaccessible content on webkit.org main page.

Using VoiceOver, many links are called "Clickable link" or "Clickable link to tweet" (instead of the relevant article title), and some images are unlabeled, causing gibberish file names to be spoken: e.g. "C-6tYGVXkAE_j6q.jpg"

Part of this was resolved in bug 172096.
Comment 1 James Craig 2017-05-15 01:13:41 PDT
Created attachment 310117 [details]
patch
Comment 2 Joseph Pecoraro 2017-05-15 11:21:44 PDT
Comment on attachment 310117 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310117&action=review

r=me

> Websites/webkit.org/wp-content/themes/webkit/widgets/post.php:62
> +                <a class="tile-link" href="<?php the_permalink(); ?>"><?php echo $title; ?></a>

Should we be escaping $title at all? (It seems we don't down below, so I'm fine with this as is).
Comment 3 James Craig 2017-05-15 14:08:08 PDT
(In reply to Joseph Pecoraro from comment #2)
> Should we be escaping $title at all? (It seems we don't down below, so I'm
> fine with this as is).

Yeah, this patch was intended to be as low risk as possible, so I just deferred to existing usage.
Comment 4 WebKit Commit Bot 2017-05-15 14:36:35 PDT
Comment on attachment 310117 [details]
patch

Clearing flags on attachment: 310117

Committed r216879: <http://trac.webkit.org/changeset/216879>
Comment 5 WebKit Commit Bot 2017-05-15 14:36:37 PDT
All reviewed patches have been landed.  Closing bug.