Bug 172106 – AX: Inaccessible content on webkit.org main page

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[James Craig]

AX: Inaccessible content on webkit.org main page.

Using VoiceOver, many links are called "Clickable link" or "Clickable link to tweet" (instead of the relevant article title), and some images are unlabeled, causing gibberish file names to be spoken: e.g. "C-6tYGVXkAE_j6q.jpg"

Part of this was resolved in bug 172096.

[James Craig]

Created attachment 310117 [details]
patch

[Joseph Pecoraro]

Comment on attachment 310117 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310117&action=review

r=me

> Websites/webkit.org/wp-content/themes/webkit/widgets/post.php:62
> +                <a class="tile-link" href="<?php the_permalink(); ?>"><?php echo $title; ?></a>

Should we be escaping $title at all? (It seems we don't down below, so I'm fine with this as is).

[James Craig]

(In reply to Joseph Pecoraro from comment #2)
> Should we be escaping $title at all? (It seems we don't down below, so I'm
> fine with this as is).

Yeah, this patch was intended to be as low risk as possible, so I just deferred to existing usage.

[WebKit Commit Bot]

Comment on attachment 310117 [details]
patch

Clearing flags on attachment: 310117

Committed r216879: <http://trac.webkit.org/changeset/216879>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.