RESOLVED FIXED 172095
[WebIDL/DOM] Remove need for custom bindings for HTMLAllCollection and bring up to spec 
https://bugs.webkit.org/show_bug.cgi?id=172095
Summary [WebIDL/DOM] Remove need for custom bindings for HTMLAllCollection and bring ...
Sam Weinig
Reported 2017-05-14 13:58:09 PDT
[WebIDL/DOM] Remove need for custom bindings for HTMLAllCollection and bring up to spec
Attachments
Patch (60.85 KB, patch)
2017-05-14 14:15 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (60.86 KB, patch)
2017-05-14 14:39 PDT, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
Patch (62.22 KB, patch)
2017-05-14 17:03 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-05-14 14:15:15 PDT
Created attachment 310096 [details] Patch
Build Bot
Comment 2 2017-05-14 14:16:38 PDT
Attachment 310096 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:50: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:51: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2017-05-14 14:39:00 PDT
Created attachment 310098 [details] Patch
Build Bot
Comment 4 2017-05-14 14:41:05 PDT
Attachment 310098 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:50: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:51: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 5 2017-05-14 16:00:19 PDT
Comment on attachment 310098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310098&action=review Both GTK and Windows build failures are: "Can't locate Clone.pm in @INC (you may need to install the Clone module)". > Source/WebCore/ChangeLog:8 > + - Adds support the legacycaller WebIDL special annotation support for > Source/WebCore/bindings/scripts/IDLParser.pm:2 > # KDOM IDL parser KDOM!
Sam Weinig
Comment 6 2017-05-14 16:41:03 PDT
(In reply to Darin Adler from comment #5) > Comment on attachment 310098 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=310098&action=review > > Both GTK and Windows build failures are: "Can't locate Clone.pm in @INC (you > may need to install the Clone module)". Yeah, I guess my excited use premature. Adding my own hand rolled clones is easy enough. > > > Source/WebCore/ChangeLog:8 > > + - Adds support the legacycaller WebIDL special annotation > > support for > Will fix. > > Source/WebCore/bindings/scripts/IDLParser.pm:2 > > # KDOM IDL parser > > KDOM! !!
Sam Weinig
Comment 7 2017-05-14 17:03:54 PDT
Created attachment 310102 [details] Patch
Build Bot
Comment 8 2017-05-14 17:05:41 PDT
Attachment 310102 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:53: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:54: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 9 2017-05-14 18:09:51 PDT
Committed r216851: <http://trac.webkit.org/changeset/216851>
Note You need to log in before you can comment on or make changes to this bug.