Bug 172089 – Unused lambda in TextFragmentIterator::TextFragment::split()

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[David Kilzer (:ddkilzer)]

<https://webkit.org/b/000000>

Reviewed by NOBODY (OOPS!).

Fixes the following warning with newer clang:

Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.h:149:39: error: lambda capture 'textFragmentIterator' is not used [-Werror,-Wunused-lambda-capture]
auto updateFragmentProperties = [&textFragmentIterator] (TextFragment& fragment, unsigned start, unsigned end, float width)
^

* rendering/SimpleLineLayoutTextFragmentIterator.h:
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::split):
- Remove unused lambda.
---
 2 files changed, 19 insertions(+), 2 deletions(-)

[David Kilzer (:ddkilzer)]

Created attachment 310065 [details]
Patch

[zalan]

Comment on attachment 310065 [details]
Patch

Let's do a bit of a cleanup here. Patch is coming up.

[zalan]

Created attachment 310091 [details]
Patch

[Konstantin Tokarev]

Comment on attachment 310091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310091&action=review

> Source/WebCore/ChangeLog:3
> +        Unused lambda in TextFragmentIterator::TextFragment::split()

It's not an accurate description of this patch anymore

[David Kilzer (:ddkilzer)]

Comment on attachment 310091 [details]
Patch

r=me

[David Kilzer (:ddkilzer)]

(In reply to Konstantin Tokarev from comment #4)
> Comment on attachment 310091 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310091&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Unused lambda in TextFragmentIterator::TextFragment::split()
> 
> It's not an accurate description of this patch anymore

The patch is still removing an unused lambda, it's just doing a little more.

[zalan]

(In reply to David Kilzer (:ddkilzer) from comment #6)
> (In reply to Konstantin Tokarev from comment #4)
> > Comment on attachment 310091 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=310091&action=review
> > 
> > > Source/WebCore/ChangeLog:3
> > > +        Unused lambda in TextFragmentIterator::TextFragment::split()
> > 
> > It's not an accurate description of this patch anymore
> 
> The patch is still removing an unused lambda, it's just doing a little more.
Indeed. Guess I could expand the title a bit.

[Build Bot]

Comment on attachment 310091 [details]
Patch

Attachment 310091 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3739235

New failing tests:
fast/css/target-fragment-match.html

[Build Bot]

Created attachment 310093 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[zalan]

Created attachment 310095 [details]
Patch

[zalan]

Comment on attachment 310093 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

Seems unrelated.

[WebKit Commit Bot]

Comment on attachment 310095 [details]
Patch

Clearing flags on attachment: 310095

Committed r216849: <http://trac.webkit.org/changeset/216849>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.