Bug 172089 - Unused lambda in TextFragmentIterator::TextFragment::split()
Summary: Unused lambda in TextFragmentIterator::TextFragment::split()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-13 22:04 PDT by David Kilzer (:ddkilzer)
Modified: 2017-05-14 14:16 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.16 KB, patch)
2017-05-13 22:04 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch (4.90 KB, patch)
2017-05-14 08:48 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (931.88 KB, application/zip)
2017-05-14 10:21 PDT, Build Bot
no flags Details
Patch (4.92 KB, patch)
2017-05-14 13:35 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-05-13 22:04:47 PDT
<https://webkit.org/b/000000>

Reviewed by NOBODY (OOPS!).

Fixes the following warning with newer clang:

Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.h:149:39: error: lambda capture 'textFragmentIterator' is not used [-Werror,-Wunused-lambda-capture]
auto updateFragmentProperties = [&textFragmentIterator] (TextFragment& fragment, unsigned start, unsigned end, float width)
^

* rendering/SimpleLineLayoutTextFragmentIterator.h:
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::split):
- Remove unused lambda.
---
 2 files changed, 19 insertions(+), 2 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2017-05-13 22:04:48 PDT
Created attachment 310065 [details]
Patch
Comment 2 zalan 2017-05-14 08:47:06 PDT
Comment on attachment 310065 [details]
Patch

Let's do a bit of a cleanup here. Patch is coming up.
Comment 3 zalan 2017-05-14 08:48:25 PDT
Created attachment 310091 [details]
Patch
Comment 4 Konstantin Tokarev 2017-05-14 09:04:59 PDT
Comment on attachment 310091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310091&action=review

> Source/WebCore/ChangeLog:3
> +        Unused lambda in TextFragmentIterator::TextFragment::split()

It's not an accurate description of this patch anymore
Comment 5 David Kilzer (:ddkilzer) 2017-05-14 09:19:09 PDT
Comment on attachment 310091 [details]
Patch

r=me
Comment 6 David Kilzer (:ddkilzer) 2017-05-14 09:20:17 PDT
(In reply to Konstantin Tokarev from comment #4)
> Comment on attachment 310091 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310091&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Unused lambda in TextFragmentIterator::TextFragment::split()
> 
> It's not an accurate description of this patch anymore

The patch is still removing an unused lambda, it's just doing a little more.
Comment 7 zalan 2017-05-14 09:22:20 PDT
(In reply to David Kilzer (:ddkilzer) from comment #6)
> (In reply to Konstantin Tokarev from comment #4)
> > Comment on attachment 310091 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=310091&action=review
> > 
> > > Source/WebCore/ChangeLog:3
> > > +        Unused lambda in TextFragmentIterator::TextFragment::split()
> > 
> > It's not an accurate description of this patch anymore
> 
> The patch is still removing an unused lambda, it's just doing a little more.
Indeed. Guess I could expand the title a bit.
Comment 8 Build Bot 2017-05-14 10:21:34 PDT
Comment on attachment 310091 [details]
Patch

Attachment 310091 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3739235

New failing tests:
fast/css/target-fragment-match.html
Comment 9 Build Bot 2017-05-14 10:21:35 PDT
Created attachment 310093 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 zalan 2017-05-14 13:35:09 PDT
Created attachment 310095 [details]
Patch
Comment 11 zalan 2017-05-14 13:35:58 PDT
Comment on attachment 310093 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

Seems unrelated.
Comment 12 WebKit Commit Bot 2017-05-14 14:16:45 PDT
Comment on attachment 310095 [details]
Patch

Clearing flags on attachment: 310095

Committed r216849: <http://trac.webkit.org/changeset/216849>
Comment 13 WebKit Commit Bot 2017-05-14 14:16:47 PDT
All reviewed patches have been landed.  Closing bug.