Bug 172079 - [cURL] Remove a call to Windows API
Summary: [cURL] Remove a call to Windows API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daewoong Jang
URL:
Keywords:
: 173963 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-05-13 17:59 PDT by Daewoong Jang
Modified: 2017-11-22 13:53 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2017-05-13 18:02 PDT, Daewoong Jang 		no flags Details | Formatted Diff | Diff
updated patch (1.28 KB, patch)
2017-06-08 22:30 PDT, Daewoong Jang 		no flags Details | Formatted Diff | Diff
updated patch (2.17 KB, patch)
2017-06-09 02:36 PDT, Daewoong Jang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daewoong Jang 2017-05-13 17:59:42 PDT 
Replace MoveFileEx with WebCore::moveFile to support curl on other platforms.
Comment 1 Daewoong Jang 2017-05-13 18:02:03 PDT 
Created attachment 310042 [details]
Patch
Comment 2 Daewoong Jang 2017-06-08 22:30:50 PDT 
Created attachment 312381 [details]
updated patch
Comment 3 Yusuke Suzuki 2017-06-09 00:34:34 PDT 
Comment on attachment 312381 [details]
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312381&action=review

> Source/WebCore/platform/network/curl/CurlDownload.cpp:342
> +    moveFile(m_tempPath, m_destination);

Is there any implementation of moveFile for Windows?
Comment 4 Daewoong Jang 2017-06-09 02:36:43 PDT 
Created attachment 312415 [details]
updated patch
Comment 5 Yusuke Suzuki 2017-06-09 03:30:48 PDT 
Comment on attachment 312415 [details]
updated patch

r=me
Comment 6 WebKit Commit Bot 2017-06-09 04:00:15 PDT 
Comment on attachment 312415 [details]
updated patch

Clearing flags on attachment: 312415

Committed r217977: <http://trac.webkit.org/changeset/217977>
Comment 7 WebKit Commit Bot 2017-06-09 04:00:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Don Olmstead 2017-11-22 13:53:40 PST 
*** Bug 173963 has been marked as a duplicate of this bug. ***