WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172079
[cURL] Remove a call to Windows API
https://bugs.webkit.org/show_bug.cgi?id=172079
Summary
[cURL] Remove a call to Windows API
Daewoong Jang
Reported
2017-05-13 17:59:42 PDT
Replace MoveFileEx with WebCore::moveFile to support curl on other platforms.
Attachments
Patch
(1.28 KB, patch)
2017-05-13 18:02 PDT
,
Daewoong Jang
no flags
Details
Formatted Diff
Diff
updated patch
(1.28 KB, patch)
2017-06-08 22:30 PDT
,
Daewoong Jang
no flags
Details
Formatted Diff
Diff
updated patch
(2.17 KB, patch)
2017-06-09 02:36 PDT
,
Daewoong Jang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Daewoong Jang
Comment 1
2017-05-13 18:02:03 PDT
Created
attachment 310042
[details]
Patch
Daewoong Jang
Comment 2
2017-06-08 22:30:50 PDT
Created
attachment 312381
[details]
updated patch
Yusuke Suzuki
Comment 3
2017-06-09 00:34:34 PDT
Comment on
attachment 312381
[details]
updated patch View in context:
https://bugs.webkit.org/attachment.cgi?id=312381&action=review
> Source/WebCore/platform/network/curl/CurlDownload.cpp:342 > + moveFile(m_tempPath, m_destination);
Is there any implementation of moveFile for Windows?
Daewoong Jang
Comment 4
2017-06-09 02:36:43 PDT
Created
attachment 312415
[details]
updated patch
Yusuke Suzuki
Comment 5
2017-06-09 03:30:48 PDT
Comment on
attachment 312415
[details]
updated patch r=me
WebKit Commit Bot
Comment 6
2017-06-09 04:00:15 PDT
Comment on
attachment 312415
[details]
updated patch Clearing flags on attachment: 312415 Committed
r217977
: <
http://trac.webkit.org/changeset/217977
>
WebKit Commit Bot
Comment 7
2017-06-09 04:00:17 PDT
All reviewed patches have been landed. Closing bug.
Don Olmstead
Comment 8
2017-11-22 13:53:40 PST
***
Bug 173963
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug