Bug 172078 - Reduce compiler warnings
Summary: Reduce compiler warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daewoong Jang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-13 17:35 PDT by Daewoong Jang
Modified: 2017-06-09 01:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (8.89 KB, patch)
2017-05-13 17:39 PDT, Daewoong Jang
no flags Details | Formatted Diff | Diff
updated patch (8.13 KB, patch)
2017-06-08 22:34 PDT, Daewoong Jang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daewoong Jang 2017-05-13 17:35:24 PDT
This patch cleans up some compiler warnings.
Comment 1 Daewoong Jang 2017-05-13 17:39:46 PDT
Created attachment 310041 [details]
Patch
Comment 2 Build Bot 2017-05-13 17:42:39 PDT
Attachment 310041 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.cpp:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Daewoong Jang 2017-05-13 17:55:41 PDT
(In reply to Build Bot from comment #2)
> Attachment 310041 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.cpp:0:  No
> copyright message found.  You should have a line: "Copyright [year]
> <Copyright Owner>"  [legal/copyright] [5]
> Total errors found: 1 in 9 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

This style error is not generated by this patch. Copyright message was already missing.
Comment 4 Daewoong Jang 2017-06-08 22:34:08 PDT
Created attachment 312382 [details]
updated patch
Comment 5 Build Bot 2017-06-08 22:35:03 PDT
Attachment 312382 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.cpp:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Yusuke Suzuki 2017-06-09 00:53:24 PDT
Comment on attachment 312382 [details]
updated patch

r=me
Comment 7 WebKit Commit Bot 2017-06-09 01:21:20 PDT
Comment on attachment 312382 [details]
updated patch

Clearing flags on attachment: 312382

Committed r217968: <http://trac.webkit.org/changeset/217968>
Comment 8 WebKit Commit Bot 2017-06-09 01:21:22 PDT
All reviewed patches have been landed.  Closing bug.