Bug 172074 - Stop using RefPtr::release()
Summary: Stop using RefPtr::release()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-13 13:25 PDT by Chris Dumez
Modified: 2017-05-13 21:04 PDT (History)
6 users (show)

See Also:

Attachments
WIP Patch (4.21 KB, patch)
2017-05-13 13:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (6.76 KB, patch)
2017-05-13 13:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (7.78 KB, patch)
2017-05-13 14:04 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (10.69 KB, patch)
2017-05-13 14:10 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (11.78 KB, patch)
2017-05-13 14:16 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (12.92 KB, patch)
2017-05-13 14:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (13.63 KB, patch)
2017-05-13 14:27 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (14.81 KB, patch)
2017-05-13 14:34 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (15.45 KB, patch)
2017-05-13 14:41 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (16.36 KB, patch)
2017-05-13 14:51 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (17.76 KB, patch)
2017-05-13 14:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (21.48 KB, patch)
2017-05-13 16:52 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (23.39 KB, patch)
2017-05-13 18:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (29.00 KB, patch)
2017-05-13 19:34 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (13) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-13 13:25:19 PDT 
Stop using RefPtr::release() and use WTFMove() instead.
Comment 1 Chris Dumez 2017-05-13 13:25:50 PDT 
Created attachment 310027 [details]
WIP Patch
Comment 2 Chris Dumez 2017-05-13 13:39:05 PDT 
Created attachment 310029 [details]
WIP Patch
Comment 3 Chris Dumez 2017-05-13 14:04:37 PDT 
Created attachment 310030 [details]
WIP Patch
Comment 4 Chris Dumez 2017-05-13 14:10:42 PDT 
Created attachment 310031 [details]
WIP Patch
Comment 5 Chris Dumez 2017-05-13 14:16:54 PDT 
Created attachment 310032 [details]
WIP Patch
Comment 6 Chris Dumez 2017-05-13 14:22:16 PDT 
Created attachment 310033 [details]
WIP Patch
Comment 7 Chris Dumez 2017-05-13 14:27:10 PDT 
Created attachment 310034 [details]
WIP Patch
Comment 8 Chris Dumez 2017-05-13 14:34:11 PDT 
Created attachment 310035 [details]
WIP Patch
Comment 9 Chris Dumez 2017-05-13 14:41:37 PDT 
Created attachment 310036 [details]
WIP Patch
Comment 10 Chris Dumez 2017-05-13 14:51:29 PDT 
Created attachment 310037 [details]
WIP Patch
Comment 11 Chris Dumez 2017-05-13 14:59:53 PDT 
Created attachment 310038 [details]
WIP Patch
Comment 12 Chris Dumez 2017-05-13 16:52:42 PDT 
Created attachment 310040 [details]
WIP Patch
Comment 13 Chris Dumez 2017-05-13 18:38:11 PDT 
Created attachment 310046 [details]
WIP Patch
Comment 14 Chris Dumez 2017-05-13 19:34:07 PDT 
Created attachment 310054 [details]
Patch
Comment 15 Chris Dumez 2017-05-13 19:35:04 PDT 
Note dropping RefPtr::release() yet as other projects still need updating.
Comment 16 Chris Dumez 2017-05-13 19:35:16 PDT 
(In reply to Chris Dumez from comment #15)
> Note dropping RefPtr::release() yet as other projects still need updating.

*Not...
Comment 17 Geoffrey Garen 2017-05-13 20:31:25 PDT 
Comment on attachment 310054 [details]
Patch

r=me
Comment 18 WebKit Commit Bot 2017-05-13 21:04:38 PDT 
Comment on attachment 310054 [details]
Patch

Clearing flags on attachment: 310054

Committed r216833: <http://trac.webkit.org/changeset/216833>
Comment 19 WebKit Commit Bot 2017-05-13 21:04:40 PDT 
All reviewed patches have been landed.  Closing bug.