RESOLVED FIXED 172074
Stop using RefPtr::release() 
https://bugs.webkit.org/show_bug.cgi?id=172074
Summary Stop using RefPtr::release()
Chris Dumez
Reported 2017-05-13 13:25:19 PDT
Stop using RefPtr::release() and use WTFMove() instead.
Attachments
WIP Patch (4.21 KB, patch)
2017-05-13 13:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (6.76 KB, patch)
2017-05-13 13:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (7.78 KB, patch)
2017-05-13 14:04 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (10.69 KB, patch)
2017-05-13 14:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (11.78 KB, patch)
2017-05-13 14:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (12.92 KB, patch)
2017-05-13 14:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (13.63 KB, patch)
2017-05-13 14:27 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (14.81 KB, patch)
2017-05-13 14:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (15.45 KB, patch)
2017-05-13 14:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (16.36 KB, patch)
2017-05-13 14:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (17.76 KB, patch)
2017-05-13 14:59 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (21.48 KB, patch)
2017-05-13 16:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (23.39 KB, patch)
2017-05-13 18:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (29.00 KB, patch)
2017-05-13 19:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-13 13:25:50 PDT
Created attachment 310027 [details] WIP Patch
Chris Dumez
Comment 2 2017-05-13 13:39:05 PDT
Created attachment 310029 [details] WIP Patch
Chris Dumez
Comment 3 2017-05-13 14:04:37 PDT
Created attachment 310030 [details] WIP Patch
Chris Dumez
Comment 4 2017-05-13 14:10:42 PDT
Created attachment 310031 [details] WIP Patch
Chris Dumez
Comment 5 2017-05-13 14:16:54 PDT
Created attachment 310032 [details] WIP Patch
Chris Dumez
Comment 6 2017-05-13 14:22:16 PDT
Created attachment 310033 [details] WIP Patch
Chris Dumez
Comment 7 2017-05-13 14:27:10 PDT
Created attachment 310034 [details] WIP Patch
Chris Dumez
Comment 8 2017-05-13 14:34:11 PDT
Created attachment 310035 [details] WIP Patch
Chris Dumez
Comment 9 2017-05-13 14:41:37 PDT
Created attachment 310036 [details] WIP Patch
Chris Dumez
Comment 10 2017-05-13 14:51:29 PDT
Created attachment 310037 [details] WIP Patch
Chris Dumez
Comment 11 2017-05-13 14:59:53 PDT
Created attachment 310038 [details] WIP Patch
Chris Dumez
Comment 12 2017-05-13 16:52:42 PDT
Created attachment 310040 [details] WIP Patch
Chris Dumez
Comment 13 2017-05-13 18:38:11 PDT
Created attachment 310046 [details] WIP Patch
Chris Dumez
Comment 14 2017-05-13 19:34:07 PDT
Created attachment 310054 [details] Patch
Chris Dumez
Comment 15 2017-05-13 19:35:04 PDT
Note dropping RefPtr::release() yet as other projects still need updating.
Chris Dumez
Comment 16 2017-05-13 19:35:16 PDT
(In reply to Chris Dumez from comment #15) > Note dropping RefPtr::release() yet as other projects still need updating. *Not...
Geoffrey Garen
Comment 17 2017-05-13 20:31:25 PDT
Comment on attachment 310054 [details] Patch r=me
WebKit Commit Bot
Comment 18 2017-05-13 21:04:38 PDT
Comment on attachment 310054 [details] Patch Clearing flags on attachment: 310054 Committed r216833: <http://trac.webkit.org/changeset/216833>
WebKit Commit Bot
Comment 19 2017-05-13 21:04:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.