Drop uses of PassRefPtr in WebKit/win.
Created attachment 310009 [details] Patch
Created attachment 310013 [details] Patch
Created attachment 310018 [details] Patch
Comment on attachment 310018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310018&action=review r=me with a nit. > Source/WebKit/win/Plugins/PluginDatabase.cpp:528 > + auto package = PluginPackage::createPackageFromCache(path, lastModified, name, desc, mimeDesc); This becomes Ref<>, so the following `package && ...`'s meaning is changed. We can drop `package` boolean check, right?
Comment on attachment 310018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310018&action=review >> Source/WebKit/win/Plugins/PluginDatabase.cpp:528 >> + auto package = PluginPackage::createPackageFromCache(path, lastModified, name, desc, mimeDesc); > > This becomes Ref<>, so the following `package && ...`'s meaning is changed. We can drop `package` boolean check, right? Right. This should not even build. It seems this code is disabled at build time on our windows bot.
Committed r216823: <http://trac.webkit.org/changeset/216823>