WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172060
Web Automation: upstream safaridriver's JavaScript atom implementations
https://bugs.webkit.org/show_bug.cgi?id=172060
Summary
Web Automation: upstream safaridriver's JavaScript atom implementations
Blaze Burg
Reported
2017-05-12 16:45:04 PDT
Carlos would like to use these and we have no reason to not put this into the tree. For safaridriver's purposes, I think we can load these from WebKit2's bundle resources at runtime.
Attachments
Patch
(22.94 KB, patch)
2017-07-11 05:44 PDT
,
Carlos Garcia Campos
bburg
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-05-12 16:45:36 PDT
<
rdar://problem/32168187
>
Carlos Garcia Campos
Comment 2
2017-05-31 00:18:16 PDT
Ping :-)
Carlos Garcia Campos
Comment 3
2017-07-11 05:44:07 PDT
Created
attachment 315098
[details]
Patch
Blaze Burg
Comment 4
2017-07-11 09:32:10 PDT
Comment on
attachment 315098
[details]
Patch r=me, but I have changed my mind about where these should go. It would be better to put these in Source/WebKit2/UIProcess/Automation/atoms/, so they can be bulk copied without having to specify each by name.
Joseph Pecoraro
Comment 5
2017-07-11 11:11:20 PDT
Comment on
attachment 315098
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=315098&action=review
> Source/WebKit2/ChangeLog:16 > + * UIProcess/Automation/ElementAttribute.js: Added. > + (lowercaseAttributeName.string_appeared_here.lowercaseAttributeName.string_appeared_here.switch): > + (tagName.string_appeared_here.lowercaseAttributeName.string_appeared_here): > + (catch): > + * UIProcess/Automation/ElementDisplayed.js: Added. > + (isShown.nodeIsElement): > + (isShown.parentElementForElement): > + (isShown.enclosingNodeOrSelfMatchingPredicate):
You can probably stop this to just the file names. I don't think the functions add value here.
Joseph Pecoraro
Comment 6
2017-07-11 11:32:14 PDT
> You can probably stop this...
I meant strip this =)
Carlos Garcia Campos
Comment 7
2017-07-12 03:56:33 PDT
Committed
r219388
: <
http://trac.webkit.org/changeset/219388
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug