RESOLVED FIXED172055
Drop remaining uses of PassRefPtr in WebKit2/WebProcess 
https://bugs.webkit.org/show_bug.cgi?id=172055
Summary Drop remaining uses of PassRefPtr in WebKit2/WebProcess
Chris Dumez
Reported 2017-05-12 15:18:17 PDT
Drop remaining uses of PassRefPtr in WebKit2/WebProcess.
Attachments
Patch (50.19 KB, patch)
2017-05-12 15:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (50.71 KB, patch)
2017-05-12 16:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (50.65 KB, patch)
2017-05-12 16:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (52.83 KB, patch)
2017-05-12 16:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (55.45 KB, patch)
2017-05-12 16:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (57.00 KB, patch)
2017-05-12 16:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (57.88 KB, patch)
2017-05-12 17:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-12 15:47:52 PDT
Created attachment 309958 [details] Patch
Build Bot
Comment 2 2017-05-12 15:50:51 PDT
Attachment 309958 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4] Total errors found: 1 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2017-05-12 16:01:21 PDT
Created attachment 309961 [details] Patch
Build Bot
Comment 4 2017-05-12 16:04:06 PDT
Attachment 309961 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4] Total errors found: 1 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 5 2017-05-12 16:07:38 PDT
Created attachment 309963 [details] Patch
Build Bot
Comment 6 2017-05-12 16:09:03 PDT
Attachment 309963 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4] Total errors found: 1 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 7 2017-05-12 16:32:40 PDT
Created attachment 309966 [details] Patch
Build Bot
Comment 8 2017-05-12 16:34:58 PDT
Attachment 309966 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4] Total errors found: 1 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 9 2017-05-12 16:41:43 PDT
Created attachment 309967 [details] Patch
Chris Dumez
Comment 10 2017-05-12 16:44:11 PDT
Created attachment 309968 [details] Patch
Build Bot
Comment 11 2017-05-12 16:45:48 PDT
Attachment 309968 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4] Total errors found: 1 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 12 2017-05-12 17:10:29 PDT
Created attachment 309972 [details] Patch
Build Bot
Comment 13 2017-05-12 17:12:00 PDT
Attachment 309972 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4] Total errors found: 1 in 44 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 14 2017-05-12 18:55:18 PDT
Comment on attachment 309972 [details] Patch Clearing flags on attachment: 309972 Committed r216810: <http://trac.webkit.org/changeset/216810>
Chris Dumez
Comment 15 2017-05-12 18:55:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.