Bug 172053 - Rename WKContentExtension to WKContentRuleList
Summary: Rename WKContentExtension to WKContentRuleList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-12 15:08 PDT by Alex Christensen
Modified: 2017-05-17 21:36 PDT (History)
4 users (show)

See Also:

Attachments
Patch (309.24 KB, patch)
2017-05-12 17:03 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (321.96 KB, patch)
2017-05-12 17:25 PDT, Alex Christensen 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-05-12 15:08:03 PDT 
Rename WKContentExtension to WKContentRuleList
Comment 1 Alex Christensen 2017-05-12 17:03:42 PDT 
Created attachment 309970 [details]
Patch
Comment 2 Build Bot 2017-05-12 17:06:24 PDT 
Attachment 309970 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/WebCompiledContentRuleList.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.h:88:  make_error_code is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:248:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:256:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:263:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:269:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:280:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:530:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:535:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 9 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2017-05-12 17:25:01 PDT 
Created attachment 309975 [details]
Patch
Comment 4 Build Bot 2017-05-12 17:28:12 PDT 
Attachment 309975 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/APIContentRuleListStoreCocoa.mm:40:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.h:88:  make_error_code is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:248:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:256:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:263:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:269:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:280:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:530:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:535:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 9 in 52 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Geoffrey Garen 2017-05-12 17:38:27 PDT 
Comment on attachment 309975 [details]
Patch

r=me
Comment 6 Alex Christensen 2017-05-12 18:33:51 PDT 
http://trac.webkit.org/r216809