RESOLVED FIXED 172053
Rename WKContentExtension to WKContentRuleList 
https://bugs.webkit.org/show_bug.cgi?id=172053
Summary Rename WKContentExtension to WKContentRuleList
Alex Christensen
Reported 2017-05-12 15:08:03 PDT
Rename WKContentExtension to WKContentRuleList
Attachments
Patch (309.24 KB, patch)
2017-05-12 17:03 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (321.96 KB, patch)
2017-05-12 17:25 PDT, Alex Christensen 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-05-12 17:03:42 PDT
Created attachment 309970 [details] Patch
Build Bot
Comment 2 2017-05-12 17:06:24 PDT
Attachment 309970 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/WebCompiledContentRuleList.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.h:88: make_error_code is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:248: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:256: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:263: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:269: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:280: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:530: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:535: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 9 in 50 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2017-05-12 17:25:01 PDT
Created attachment 309975 [details] Patch
Build Bot
Comment 4 2017-05-12 17:28:12 PDT
Attachment 309975 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/APIContentRuleListStoreCocoa.mm:40: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.h:88: make_error_code is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:248: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:256: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:263: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:269: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:280: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:530: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIContentRuleListStore.cpp:535: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 9 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 5 2017-05-12 17:38:27 PDT
Comment on attachment 309975 [details] Patch r=me
Alex Christensen
Comment 6 2017-05-12 18:33:51 PDT
http://trac.webkit.org/r216809
Note You need to log in before you can comment on or make changes to this bug.