Bug 172044 – [macOS Debug] Layout Test imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html is a flaky timeout.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Matt Lewis]

The test imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html is a flaky timeout.

The test recently started to timeout on Sierra Debug WK2 on 5/10/17, however this does not seem to be a recent occurrence. It has been timing out on both versions (WK1 & WK2) of El Capitan and the Sierra Debug WK1 for as far back as the dashboard will allow.

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2FIndexedDB%2Fopen-request-queue.html

Build:
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/963
https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r216764%20(963)/results.html


no diff available

imported with https://trac.webkit.org/changeset/212202/webkit

[Matt Lewis]

Marked as flaky timeout:
https://trac.webkit.org/changeset/220932/webkit

[Matt Lewis]

This is now happening on wk! as well:

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r225411%20(5072)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/5072

Added expectations for wk1 in:
https://trac.webkit.org/changeset/225432/webkit

[Sihui Liu]

Created attachment 433962 [details]
Patch

[Chris Dumez]

Comment on attachment 433962 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433962&action=review

The code change looks acceptable but landing FAIL baselines for tests is not.

> LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:29
> +FAIL sawVersionChange should be true. Was false.

Since those are WebKit tests (not WPT), please fix those tests to reflect the new behavior instead of landing failure expectations.

[Sihui Liu]

Created attachment 433973 [details]
Patch

[EWS]

Committed r280176 (239871@main): <https://commits.webkit.org/239871@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433973 [details].

[Radar WebKit Bug Importer]

<rdar://problem/80967124>