Bug 172035 - Memory pressure response should only do sync bmalloc scavenge in sync mode.
Summary: Memory pressure response should only do sync bmalloc scavenge in sync mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2017-05-12 10:14 PDT by Andreas Kling
Modified: 2017-05-12 11:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2017-05-12 10:18 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2017-05-12 10:14:38 PDT 
Telling bmalloc to synchronously scavenge when we're not in a hurry is silly. Let's not be that silly.
Comment 1 Andreas Kling 2017-05-12 10:18:54 PDT 
Created attachment 309909 [details]
Patch
Comment 2 Michael Saboff 2017-05-12 10:24:37 PDT 
Comment on attachment 309909 [details]
Patch

r=me
Comment 3 Michael Saboff 2017-05-12 10:32:48 PDT 
One thing to note, in my testing on iOS all memory pressure notifications are critical.  I have never seen WARN events.
Comment 4 WebKit Commit Bot 2017-05-12 11:21:48 PDT 
Comment on attachment 309909 [details]
Patch

Clearing flags on attachment: 309909

Committed r216770: <http://trac.webkit.org/changeset/216770>
Comment 5 WebKit Commit Bot 2017-05-12 11:21:50 PDT 
All reviewed patches have been landed.  Closing bug.