Bug 172022 – [MediaStream] Streams while play while page is in background can get "stuck" when page is forgrounded.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[MediaStream] Streams while play while page is in background can get "stuck" when page is forgrounded.

[Radar WebKit Bug Importer]

<rdar://problem/32151246>

[Jer Noble]

Created attachment 309880 [details]
Patch

[youenn fablet]

Comment on attachment 309880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309880&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:-123
> -    void setVisible(bool) override { /* No-op */ }

Should be final

[youenn fablet]

A test might be good as well here or as a followup

[Jer Noble]

(In reply to youenn fablet from comment #4)
> A test might be good as well here or as a followup

We don't have a way to extract the current displayed image from an AVSampleBufferDisplayLayer (which is what we'd need to test).

[Jer Noble]

Created attachment 309896 [details]
Patch for landing

[youenn fablet]

By the way, should we try to optimize the case of a video element being not visible?
It should be possible to ask the source to stop sending frames.

Also, is there a relationship between this bug and the fact the webrtc incoming video track is setting frames to be rendered as kCMSampleAttachmentKey_DisplayImmediately?

[WebKit Commit Bot]

Comment on attachment 309896 [details]
Patch for landing

Clearing flags on attachment: 309896

Committed r216766: <http://trac.webkit.org/changeset/216766>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jon Lee]

This introduced a bug with PiP on Mac.