Bug 172010 - RenderImageResource::hasImage is redundant and RenderImageResourceStyleImage's override is incorrect.
Summary: RenderImageResource::hasImage is redundant and RenderImageResourceStyleImage'...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-11 19:31 PDT by zalan
Modified: 2017-05-11 20:56 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.22 KB, patch)
2017-05-11 19:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.21 KB, patch)
2017-05-11 20:13 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-05-11 19:31:24 PDT 
RenderImageResourceStyleImage::hasImage always returns true which is incorrect see RenderImageResourceStyleImage::image()
Comment 1 zalan 2017-05-11 19:32:15 PDT 
rdar://problem/31086735
Comment 2 zalan 2017-05-11 19:37:48 PDT 
Created attachment 309849 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-05-11 19:41:38 PDT 
Comment on attachment 309849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309849&action=review

> LayoutTests/fast/images/missing-content-image-crash.html:19
> +missingImage.style.content = "url('http://fakeurl.with-missing.jpg/missing.jpg')";

I think we avoid tests that make random http requests, even if they are to bogus hosts. Not sure if we have canonical test host (example.com?).
Comment 4 zalan 2017-05-11 20:13:05 PDT 
Created attachment 309856 [details]
Patch
Comment 5 WebKit Commit Bot 2017-05-11 20:56:00 PDT 
Comment on attachment 309856 [details]
Patch

Clearing flags on attachment: 309856

Committed r216728: <http://trac.webkit.org/changeset/216728>
Comment 6 WebKit Commit Bot 2017-05-11 20:56:02 PDT 
All reviewed patches have been landed.  Closing bug.