Bug 172008 - WebAssembly: implement name section's module name
Summary: WebAssembly: implement name section's module name
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
Depends on:
Blocks: 159775 174098
  Show dependency treegraph
Reported: 2017-05-11 19:20 PDT by JF Bastien
Modified: 2017-07-05 13:51 PDT (History)
8 users (show)

See Also:

patch (5.02 KB, patch)
2017-07-03 08:32 PDT, JF Bastien
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2017-05-11 19:20:16 PDT
See https://github.com/WebAssembly/design/pull/1055
Comment 1 JF Bastien 2017-07-03 08:32:48 PDT
Created attachment 314485 [details]
Comment 2 Build Bot 2017-07-03 08:33:46 PDT
Attachment 314485 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/wasm/WasmFormat.h:248:  static_cast is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Keith Miller 2017-07-05 09:23:00 PDT
Comment on attachment 314485 [details]

Comment 4 WebKit Commit Bot 2017-07-05 09:52:02 PDT
Comment on attachment 314485 [details]

Clearing flags on attachment: 314485

Committed r219134: <http://trac.webkit.org/changeset/219134>
Comment 5 WebKit Commit Bot 2017-07-05 09:52:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Saam Barati 2017-07-05 13:51:38 PDT
Comment on attachment 314485 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=314485&action=review

> Source/JavaScriptCore/ChangeLog:26
> +        so I can't write a simple binary test; and using the name is a
> +        slightly riskier change because it requires changing StackVisitor
> +        + StackFrame (where they print "[wasm code]") which requires
> +        figuring out the frame's Module. The latter bit isn't trivial
> +        because we only know wasm frames from their tag bits, and
> +        CodeBlocks are always nullptr.

I think we should just have Wasm::Callee's know their names. We can also have Wasm::Callee know its module. I don't think it's bad for these to grow a bit in size. This seems inevitable for doing wasm debugging.