See https://github.com/WebAssembly/design/pull/1055
Created attachment 314485 [details] patch
Attachment 314485 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmFormat.h:248: static_cast is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 314485 [details] patch r=me.
Comment on attachment 314485 [details] patch Clearing flags on attachment: 314485 Committed r219134: <http://trac.webkit.org/changeset/219134>
All reviewed patches have been landed. Closing bug.
Comment on attachment 314485 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=314485&action=review > Source/JavaScriptCore/ChangeLog:26 > + so I can't write a simple binary test; and using the name is a > + slightly riskier change because it requires changing StackVisitor > + + StackFrame (where they print "[wasm code]") which requires > + figuring out the frame's Module. The latter bit isn't trivial > + because we only know wasm frames from their tag bits, and > + CodeBlocks are always nullptr. I think we should just have Wasm::Callee's know their names. We can also have Wasm::Callee know its module. I don't think it's bad for these to grow a bit in size. This seems inevitable for doing wasm debugging.