Bug 172007 – Drop remaining uses of PassRefPtr under platform/

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Chris Dumez]

Drop remaining uses of PassRefPtr under platform/.

[Chris Dumez]

Created attachment 309843 [details]
Patch

[Chris Dumez]

Created attachment 309846 [details]
Patch

[Geoffrey Garen]

Comment on attachment 309846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309846&action=review

rs=me

> Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:147
> +static bool MockSourceBufferPrivateHasAudio(MockSourceBufferPrivate* sourceBuffer)

Maybe MockSourceBufferPrivate&?

> Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:157
> +static bool MockSourceBufferPrivateHasVideo(MockSourceBufferPrivate* sourceBuffer)

Maybe MockSourceBufferPrivate&?

[Ryosuke Niwa]

Wait, if you want Chris to fix that, you can't cq+ it. commit-queue will just land it as is.

[WebKit Commit Bot]

Comment on attachment 309846 [details]
Patch

Rejecting attachment 309846 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 309846, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
entMock.h
patching file Source/WebCore/platform/mock/RTCNotifiersMock.cpp
patching file Source/WebCore/platform/mock/RTCNotifiersMock.h
patching file Source/WebCore/platform/mock/TimerEventBasedMock.h
patching file Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp
patching file Source/WebCore/platform/wpe/RenderThemeWPE.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Geoffrey Garen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3723135

[Chris Dumez]

Comment on attachment 309846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309846&action=review

>> Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:147
>> +static bool MockSourceBufferPrivateHasAudio(MockSourceBufferPrivate* sourceBuffer)
> 
> Maybe MockSourceBufferPrivate&?

This is passed to std::any_of() with a vector that contains raw pointers.

>> Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:157
>> +static bool MockSourceBufferPrivateHasVideo(MockSourceBufferPrivate* sourceBuffer)
> 
> Maybe MockSourceBufferPrivate&?

This is passed to std::any_of() with a vector that contains raw pointers.

[Chris Dumez]

Created attachment 309855 [details]
Patch

[Chris Dumez]

Comment on attachment 309855 [details]
Patch

Clearing flags on attachment: 309855

Committed r216724: <http://trac.webkit.org/changeset/216724>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.