Bug 172000 - Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
Summary: Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-11 16:40 PDT by David Quesada
Modified: 2017-05-12 16:29 PDT (History)
3 users (show)

See Also:

Attachments
Patch (15.52 KB, patch)
2017-05-11 16:44 PDT, David Quesada 		no flags Details | Formatted Diff | Diff
Patch v2 (15.96 KB, patch)
2017-05-12 16:00 PDT, David Quesada 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Quesada 2017-05-11 16:40:00 PDT 
rdar://problem/32144756
Comment 1 David Quesada 2017-05-11 16:44:29 PDT 
Created attachment 309821 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-05-12 15:34:15 PDT 
Comment on attachment 309821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309821&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2178
> +- (UIView *)_enclosingView

I think this name is too generic; it could easily conflict with a UIKit method, and it has a very particular usage, so we should name it accordingly.

How about _enclosingViewForExposedRectComputation?
Comment 3 David Quesada 2017-05-12 15:40:28 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 309821 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309821&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2178
> > +- (UIView *)_enclosingView
> 
> I think this name is too generic; it could easily conflict with a UIKit
> method, and it has a very particular usage, so we should name it accordingly.
> 
> How about _enclosingViewForExposedRectComputation?

Sure.
Comment 4 David Quesada 2017-05-12 16:00:27 PDT 
Created attachment 309960 [details]
Patch v2
Comment 5 WebKit Commit Bot 2017-05-12 16:29:32 PDT 
Comment on attachment 309960 [details]
Patch v2

Clearing flags on attachment: 309960

Committed r216802: <http://trac.webkit.org/changeset/216802>
Comment 6 WebKit Commit Bot 2017-05-12 16:29:34 PDT 
All reviewed patches have been landed.  Closing bug.