Bug 172000 – Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[David Quesada]

rdar://problem/32144756

[David Quesada]

Created attachment 309821 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 309821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309821&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2178
> +- (UIView *)_enclosingView

I think this name is too generic; it could easily conflict with a UIKit method, and it has a very particular usage, so we should name it accordingly.

How about _enclosingViewForExposedRectComputation?

[David Quesada]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 309821 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309821&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2178
> > +- (UIView *)_enclosingView
> 
> I think this name is too generic; it could easily conflict with a UIKit
> method, and it has a very particular usage, so we should name it accordingly.
> 
> How about _enclosingViewForExposedRectComputation?

Sure.

[David Quesada]

Created attachment 309960 [details]
Patch v2

[WebKit Commit Bot]

Comment on attachment 309960 [details]
Patch v2

Clearing flags on attachment: 309960

Committed r216802: <http://trac.webkit.org/changeset/216802>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.