Bug 171998 - Web Inspector: RTL: Text in autocomplete popover should be aligned left
Summary: Web Inspector: RTL: Text in autocomplete popover should be aligned left
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-11 16:16 PDT by Nikita Vasilyev
Modified: 2017-05-22 11:27 PDT (History)
3 users (show)

See Also:

Attachments
[Image] Bug (66.95 KB, image/png)
2017-05-11 16:16 PDT, Nikita Vasilyev 		no flags Details
Patch (1.22 KB, patch)
2017-05-11 16:26 PDT, Nikita Vasilyev 		bburg: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2017-05-11 16:16:56 PDT 
Created attachment 309812 [details]
[Image] Bug

Autocomplete popover is used for CSS and JS, that are always LTR.
Comment 1 Nikita Vasilyev 2017-05-11 16:26:19 PDT 
Created attachment 309814 [details]
Patch
Comment 2 BJ Burg 2017-05-11 17:12:01 PDT 
Comment on attachment 309814 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2017-05-11 17:50:01 PDT 
Comment on attachment 309814 [details]
Patch

Rejecting attachment 309814 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 309814, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/3722287
Comment 4 BJ Burg 2017-05-22 11:27:40 PDT 
Committed r217229: <http://trac.webkit.org/changeset/217229>